Java: adjust comments

Jami Cogswell · Jami Cogswell · commit feaae16f7cb7 · 2023-01-03T16:08:14.000-05:00
diff --git a/java/ql/lib/ext/java.sql.model.yml b/java/ql/lib/ext/java.sql.model.yml
@@ -28,4 +28,4 @@ extensions:
       pack: codeql/java-all
       extensible: neutralModel
     data:
-      - ["java.sql", "ResultSet", "next", "()", "manual"] # ! unsure if should be neutral model
+      - ["java.sql", "ResultSet", "next", "()", "manual"]
diff --git a/java/ql/lib/ext/java.text.model.yml b/java/ql/lib/ext/java.text.model.yml
@@ -3,5 +3,5 @@ extensions:
       pack: codeql/java-all
       extensible: neutralModel
     data:
-      - ["java.text", "DateFormat", "format", "(Date)", "manual"]  # ! unsure if should be neutral model, is flow through the param interesting in this case?
-      - ["java.text", "SimpleDateFormat", "SimpleDateFormat", "(String)", "manual"]  # ! unsure if should be neutral model, is flow through the param interesting in this case?
+      - ["java.text", "DateFormat", "format", "(Date)", "manual"]
+      - ["java.text", "SimpleDateFormat", "SimpleDateFormat", "(String)", "manual"]
diff --git a/java/ql/lib/ext/java.time.model.yml b/java/ql/lib/ext/java.time.model.yml
@@ -4,5 +4,5 @@ extensions:
       extensible: neutralModel
     data:
       - ["java.time", "Instant", "now", "()", "manual"]
-      - ["java.time", "LocalDate", "of", "(int,int,int)", "manual"] # ! unsure if should be neutral model, is flow through the param interesting in this case?
+      - ["java.time", "LocalDate", "of", "(int,int,int)", "manual"]
       - ["java.time", "ZonedDateTime", "now", "()", "manual"]
diff --git a/java/ql/lib/ext/java.util.function.model.yml b/java/ql/lib/ext/java.util.function.model.yml
@@ -9,11 +9,11 @@ extensions:
       pack: codeql/java-all
       extensible: summaryModel
     data:
-      - ["java.util.function", "Function", True, "apply", "(Object)", "", "Argument[0]", "ReturnValue", "taint", "manual"] # ! unsure if should be added as a MaD model and if model is correct
+      - ["java.util.function", "Function", True, "apply", "(Object)", "", "Argument[0]", "ReturnValue", "taint", "manual"]
       - ["java.util.function", "Supplier", False, "get", "()", "", "Argument[-1]", "ReturnValue", "value", "manual"]
 
   - addsTo:
       pack: codeql/java-all
       extensible: neutralModel
     data:
-      - ["java.util.function", "Consumer", "accept", "(Object)", "manual"] # ! unsure if should be neutral model
+      - ["java.util.function", "Consumer", "accept", "(Object)", "manual"]
diff --git a/java/ql/lib/ext/java.util.model.yml b/java/ql/lib/ext/java.util.model.yml
@@ -369,7 +369,7 @@ extensions:
       - ["java.util", "Collections", "emptyList", "()", "manual"]
       - ["java.util", "Collections", "emptyMap", "()", "manual"]
       - ["java.util", "Collections", "emptySet", "()", "manual"]
-      - ["java.util", "Date", "Date", "(long)", "manual"] # ! unsure if should be neutral model, is flow through the param interesting in this case?
+      - ["java.util", "Date", "Date", "(long)", "manual"]
       - ["java.util", "Date", "getTime", "()", "manual"]
       - ["java.util", "Iterator", "hasNext", "()", "manual"]
       - ["java.util", "List", "clear", "()", "manual"]
diff --git a/java/ql/lib/ext/java.util.stream.model.yml b/java/ql/lib/ext/java.util.stream.model.yml
@@ -92,7 +92,7 @@ extensions:
       pack: codeql/java-all
       extensible: neutralModel
     data:
-      - ["java.util.stream", "Collectors", "joining", "(CharSequence)", "manual"] # ! unsure if should be neutral model, is flow through the param interesting in this case?
+      - ["java.util.stream", "Collectors", "joining", "(CharSequence)", "manual"]
       - ["java.util.stream", "Collectors", "toList", "()", "manual"]
-      - ["java.util.stream", "Collectors", "toMap", "(Function,Function)", "manual"] # ! unsure if should be neutral model, is flow through the param interesting in this case?
+      - ["java.util.stream", "Collectors", "toMap", "(Function,Function)", "manual"]
       - ["java.util.stream", "Collectors", "toSet", "()", "manual"]
