Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ATM: Use ${workspace} for CodeQL pack workspace references #11127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2022

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Nov 4, 2022

This fixes the ATM PR checks, which broke on main as a result of the JavaScript pack being updated to use ${workspace} in #11004.

@github-actions github-actions bot added the ATM label Nov 4, 2022
@henrymercer henrymercer added the no-change-note-required This PR does not need a change note label Nov 4, 2022
@henrymercer henrymercer marked this pull request as ready for review November 4, 2022 14:15
@henrymercer henrymercer requested a review from a team November 4, 2022 14:15
Copy link
Collaborator

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible, LGTM if tests pass.

Copy link
Contributor

@dbartol dbartol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should fix it, although I think I would not have expected it to fail. I've opened https://github.com/github/codeql-core/issues/2937 for further investigation.

@dbartol dbartol merged commit 649c3af into main Nov 4, 2022
@dbartol dbartol deleted the henrymercer/fix-atm-pr-checks branch November 4, 2022 16:19
@henrymercer henrymercer changed the title ATM: Fix CodeQL pack workspace references ATM: Use ${workspace} for CodeQL pack workspace references Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ATM no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants