Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Java: Add binding between annotation and sink-param in MyBatis SQL Injection query #11368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atorralba merged 5 commits into from
Nov 24, 2022
Merged

Java: Add binding between annotation and sink-param in MyBatis SQL Injection query #11368

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce2ba21
Add binding between annotation and sink-param
ka1n4t Nov 22, 2022
d113fb2
Add test case for PR-11368
ka1n4t Nov 23, 2022
443d0f5
Apply suggestions from code review
atorralba Nov 24, 2022
17218fa
Formatting
atorralba Nov 24, 2022
4bbc1dc
Update test expectations
atorralba Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add binding between annotation and sink-param
  • Loading branch information
@ka1n4t
ka1n4t committed Nov 22, 2022
commit ce2ba21240e6690b3819178c8eccead8e12941b4
3 changes: 2 additions & 1 deletion java/ql/src/experimental/Security/CWE/CWE-089/MyBatisCommonLib.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,8 @@ predicate isMybatisXmlOrAnnotationSqlInjection(
.matches("${" + annotation.getValue("value").(CompileTimeConstantExpr).getStringValue() +
"%}") and
annotation.getType() instanceof TypeParam and
ma.getAnArgument() = node.asExpr()
ma.getAnArgument() = node.asExpr() and
annotation.getTarget() = ma.getMethod().getParameter(node.asExpr().getIndex())
Comment thread
atorralba marked this conversation as resolved.
Outdated
)
or
// MyBatis default parameter sql injection vulnerabilities.the default parameter form of the method is arg[0...n] or param[1...n].
Expand Down