Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Go: Improved JWT query, JWT decoding without verification #14075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
owen-mc merged 21 commits into from
Oct 11, 2023
Merged

Go: Improved JWT query, JWT decoding without verification #14075

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
68392e7
V1
am0o0 Aug 28, 2023
40ff16b
Merge branch 'main' into amammad-go-JWT
am0o0 Aug 29, 2023
bc6a0fc
move to CWE-347
am0o0 Sep 18, 2023
2136929
clean tests
am0o0 Sep 19, 2023
1e12a86
Merge branch 'main' into amammad-go-JWT
am0o0 Sep 19, 2023
a96b001
clean tests
am0o0 Sep 19, 2023
da864bf
fix QLDoc
am0o0 Sep 19, 2023
c78f390
add go generate support, upgrade JWT.qll
am0o0 Sep 27, 2023
8d47a7b
Update python/ql/lib/semmle/python/security/dataflow/PathInjectionQue…
am0o0 Sep 28, 2023
f0f60c3
move JWT.qll to experimental
am0o0 Sep 30, 2023
aa127b1
do review improvements
am0o0 Oct 6, 2023
7d73808
fix a test mistake, add comments for JWT extension points
am0o0 Oct 6, 2023
7d36c23
fix qhelp and PascalCase issues
am0o0 Oct 6, 2023
2579791
fix examples
am0o0 Oct 9, 2023
38b0ed8
fix issues according to codereview
am0o0 Oct 10, 2023
82483a2
fix tests
am0o0 Oct 10, 2023
db9f74b
fix tests
am0o0 Oct 10, 2023
877605d
change c to C for fixing the qhelp error :)
am0o0 Oct 10, 2023
4499048
better query quality thanks to owen
am0o0 Oct 10, 2023
5e27323
fix qldoc
am0o0 Oct 11, 2023
8a3aa2c
Fix formatting
owen-mc Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
better query quality thanks to owen
  • Loading branch information
@am0o0
am0o0 committed Oct 10, 2023
commit 4499048d8e6c16dbc449e802f6b20517edbca4c6
14 changes: 4 additions & 10 deletions go/ql/src/experimental/CWE-321-V2/HardCodedKeys.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,22 +20,16 @@ module JwtParseWithConstantKeyConfig implements DataFlow::ConfigSig {
// Find a node that has flow to a key Function argument
// then find the first result node of this Function which is the secret key
exists(FuncDef fd, DataFlow::Node n, DataFlow::ResultNode rn |
fd = n.asExpr()
or
n = fd.(FuncDecl).getFunction().getARead()
|
GolangJwtKeyFunc::flow(n, _) and
sink = rn and
fd = n.asExpr() and
rn.getRoot() = fd and
rn.getIndex() = 0
)
Comment on lines +22 to +31
Copy link
Copy Markdown
Contributor

@owen-mc owen-mc Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two exists have a huge amount in common. It would be better to combine them into one exists.

Copy link
Copy Markdown
Contributor Author

@am0o0 am0o0 Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think If I merge them it can be much longer that it is.

or
exists(Function f, DataFlow::ResultNode rn |
GolangJwtKeyFunc::flow(f.getARead(), _) and
// sink is result of a method
sink = rn and
// the method is belong to a function in which is used as a JWT function key
rn.getRoot() = f.getFuncDecl() and
rn.getIndex() = 0
)
or
// second part is the JWT Parsing Functions that get a string or byte as an argument
sink = any(JwtParse jp).getKeyArg()
}
Expand Down