C#: Use C'X fully-qualified-name format instead of C<,...,>#14589
Merged
hvitved merged 5 commits intogithub:mainfrom Nov 10, 2023
Merged
C#: Use C'X fully-qualified-name format instead of C<,...,>#14589hvitved merged 5 commits intogithub:mainfrom
C'X fully-qualified-name format instead of C<,...,>#14589hvitved merged 5 commits intogithub:mainfrom
Conversation
CX FQN format instead of C<,...,>`CX` FQN format instead of C<,...,>`
CX` FQN format instead of C<,...,>` CX ` FQN format instead of C<,...,>`
CX ` FQN format instead of C<,...,>`C'X FQN format instead of C<,...,>
C'X FQN format instead of C<,...,>C'X fully-qualified-name format instead of C<,...,>
8694747 to
9fd38b6
Compare
f75d903 to
ccaa530
Compare
Contributor
|
|
ccaa530 to
7bc094d
Compare
7bc094d to
bcf4d7a
Compare
bcf4d7a to
57ec094
Compare
tamasvajk
reviewed
Nov 10, 2023
Contributor
tamasvajk
left a comment
There was a problem hiding this comment.
Looks good to me. Mostly based on that CI is green and there's no MaD change in the PR.
michaelnebel
approved these changes
Nov 10, 2023
Contributor
michaelnebel
left a comment
There was a problem hiding this comment.
Great work @hvitved !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes our rendering of fully qualified names for unbound generics from the non-standard
C<,...,>format, to the standardC`Xformat, whereXis the number of type parameters. This is, of course, a breaking change, so instead of directly changing{has,get}QualifiedNameto use the new format, I have instead deprecated{has,get}QualifiedName, and introduced new{has,get}FullyQualifiedNamepredicates that use the new format.The existing
getNamepredicate has been adjusted, so it also uses the new format instead of the old format, here it was not natural to deprecate the predicate and come up with a new name.