C++: Handle explicitly instantiated templates #16075
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates expected test outputs to account for explicitly instantiated templates introduced by recent extractor changes.
- Added duplicate “I” (instantiated) entries alongside “T” (template) entries across multiple test expectations.
- Inserted new function and class template instantiation tests for
load,foo, and switch-case scenarios. - Updated instantiation directive tests to include
foo<float>andfoo<int>.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/test/library-tests/templates/switch/test.expected | Added duplicated switch-case entry for explicit instantiation |
| cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/isfromuninstantiatedtemplate.expected | Added “I” entries for definitions, statements, and expressions |
| cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/isfromtemplateinstantiation.expected | Added explicit instantiation entries for member function f |
| cpp/ql/test/library-tests/templates/isfromtemplateinstantiation/instantiations.expected | Added a load<short> FunctionTemplateInstantiation entry |
| cpp/ql/test/library-tests/templates/instantiation_directive/functions.expected | Added foo instantiations for float and int |
...est/library-tests/templates/isfromtemplateinstantiation/isfromtemplateinstantiation.expected
Show resolved
Hide resolved
cpp/ql/test/library-tests/templates/instantiation_directive/functions.expected
Show resolved
Hide resolved
8ed10d1 to
fac63cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test updates after extractor changes