Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Python: enable diff-informed data flow queries #18341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgerf merged 7 commits into from
Feb 11, 2025
Merged

Python: enable diff-informed data flow queries #18341

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e4a1847
Python: mass enable diff-informed data flow
asgerf Jan 23, 2025
9dfd1cc
Python: Fixup broken patch
asgerf Jan 23, 2025
15c2ccb
Python: ignore experimental for now
asgerf Jan 23, 2025
975ce06
Python: implement for polynomial redos
asgerf Jan 23, 2025
d3ee658
Python: resolve remaining TODOs
asgerf Dec 20, 2024
7d6abb4
JS: Disable diff-informedness for full SSRF
asgerf Feb 6, 2025
d3b9d1d
JS: Partial SSRF does not select the sink location
asgerf Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
JS: Disable diff-informedness for full SSRF 
Partial SSRF uses its result in a way that prevents diff-informedness
  • Loading branch information
@asgerf
asgerf committed Feb 6, 2025
commit 7d6abb4e0a87ff25bb9265dc9e18bf7319f1af48
10 changes: 4 additions & 6 deletions python/ql/lib/semmle/python/security/dataflow/ServerSideRequestForgeryQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,10 @@ private module FullServerSideRequestForgeryConfig implements DataFlow::ConfigSig
node instanceof FullUrlControlSanitizer
}

predicate observeDiffInformedIncrementalMode() { any() }

Location getASelectedSinkLocation(DataFlow::Node sink) {
result = sink.(Sink).getLocation()
or
result = sink.(Sink).getRequest().getLocation()
predicate observeDiffInformedIncrementalMode() {
// The partial request forgery query depends on `fullyControlledRequest` to reject alerts about
// such full-controlled requests, regardless of the associated source.
none()
}
}

Expand Down