Rust: Recognize more sensitive data sources #19470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances Rust sensitive data analysis by expanding test coverage for various sensitive and non-sensitive patterns and by extending the CodeQL model to recognize enum variants and field accesses as potential sensitive sources.
- Added new test cases in
test.rsfor additional sensitive data identifiers (e.g., MFA, backup codes, device info, private info) and corresponding non-sensitive examples. - Extended
SensitiveData.qllwithSensitiveDataVariant,SensitiveDataVariantCall, andSensitiveFieldAccessto capture enum variant calls and field accesses. - Left heuristic logic unchanged, deferring improvements to a follow-up PR.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| rust/ql/test/library-tests/sensitivedata/test.rs | Expanded tests for more Rust constructs and data patterns (fields, qualifiers, variants) |
| rust/ql/lib/codeql/rust/security/SensitiveData.qll | Added classes to model enum variants, variant calls, and field accesses as sensitive |
Comments suppressed due to low confidence (2)
rust/ql/test/library-tests/sensitivedata/test.rs:68
- [nitpick] The variable name
passwordFileuses camelCase; prefer snake_case (e.g.,password_file) for consistency with Rust naming conventions.
sink(passwordFile); // $ SPURIOUS: sensitive=password
rust/ql/test/library-tests/sensitivedata/test.rs:140
- [nitpick] Field name
deviceApiTokenuses camelCase; prefer snake_case (device_api_token) to align with Rust community style.
deviceApiToken: String,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve Rust sensitive data analysis:
What I haven't done here is improve the heuristics themselves to catch more kinds of sensitive data such as those in the new tests. That change will affect all languages, so I'd rather do it in a separate PR following this one.
TODO: