Thanks to visit codestin.com
Credit goes to github.com

Skip to content

JS: Explicitly Filter Quality Queries for Inclusion in Security-and-Quality #19578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

JS: Explicitly Filter Quality Queries for Inclusion in Security-and-Quality #19578

merged 2 commits into from
May 27, 2025

Conversation

Napalys
Copy link
Contributor

@Napalys Napalys commented May 26, 2025 •
edited
Loading

This PR explicitly hardcodes all the quality query IDs within the JavaScript security and quality suite. Similar to #19245

@github-actions github-actions bot added the JS label May 26, 2025
@Napalys Napalys force-pushed the js/security_quality_suite branch from 01d4fd3 to 52a15df Compare May 26, 2025 08:39
@Napalys Napalys force-pushed the js/security_quality_suite branch from 52a15df to 37024ad Compare May 26, 2025 09:00
@Napalys Napalys marked this pull request as ready for review May 26, 2025 09:27
@Copilot Copilot AI review requested due to automatic review settings May 26, 2025 09:27
@Napalys Napalys requested a review from a team as a code owner May 26, 2025 09:27
Copilot
Copilot AI reviewed May 26, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

michaelnebel
michaelnebel reviewed May 27, 2025
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!
Maybe consider removing the parts of the filtering that does't have any effect for JS.

michaelnebel
michaelnebel approved these changes May 27, 2025
View reviewed changes
Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 😄

@Napalys Napalys merged commit 99ab144 into github:main May 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@michaelnebel michaelnebel michaelnebel approved these changes

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Napalys @michaelnebel