C++: Add support for getting literals in using declarations #19603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff24105 to
20edf34
Compare
20edf34 to
b322892
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds the ability to retrieve the specific member referenced by a using declaration in a templated base class and updates toString() to fall back to this new API.
- Introduces
getReferencedMember()inUsingDeclarationEntry. - Modifies
toString()to usegetDeclaration()first orgetReferencedMember()as a fallback. - Documents the feature in a new change-notes entry.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cpp/ql/lib/semmle/code/cpp/Namespace.qll | Added getReferencedMember() and updated toString() |
| cpp/ql/lib/change-notes/2025-05-28-using-template.md | Added feature note for getReferencedMember |
Comments suppressed due to low confidence (2)
cpp/ql/lib/semmle/code/cpp/Namespace.qll:191
- The use of
orbetween two assignment statements here is invalid syntax and won't produce the intended fallback behavior. Consider computing both descriptions first or use a conditional expression to assign a singleresultvalue.
result = "using " + this.getDeclaration().getDescription() or
cpp/ql/lib/semmle/code/cpp/Namespace.qll:192
getReferencedMember()returns anElement, not astring. You need to call its.getDescription()(or equivalent) to produce a textual representation.
result = "using " + this.getReferencedMember()
geoffw0
reviewed
May 30, 2025
237e296 to
d6fbb31
Compare
jketema
reviewed
Jun 3, 2025
jketema
reviewed
Jun 3, 2025
Comment on lines
183
to
186
| * class A : public T { | ||
| * using T::foo; // `foo` is the member referenced by this using declaration | ||
| * }; |
Contributor
There was a problem hiding this comment.
Is it actually relevant that T is a base class of A, or would the following also yield a result:
template <typename T>
class A {
using T::foo;
};
d6fbb31 to
79df7b9
Compare
79df7b9 to
770708f
Compare
770708f to
a0dbe0e
Compare
jketema
reviewed
Jun 3, 2025
Contributor
jketema
left a comment
There was a problem hiding this comment.
Some small tweaks of the change note and QLDoc, otherwise LGTM.
Comment on lines
178
to
179
| * Returns the member referenced by this using declaration when it refers | ||
| * to a member of a template type parameter. |
Contributor
There was a problem hiding this comment.
Trying to make it a bit more uniform with the getDeclaration QLDoc, and using the word "depends", which is what the standard uses:
Suggested change
| * Returns the member referenced by this using declaration when it refers | |
| * to a member of a template type parameter. | |
| * Gets the member that is referenced by this using declaration, where the member depends on a | |
| * type template parameter. |
| * ``` | ||
| * template <typename T> | ||
| * class A { | ||
| * using T::foo; // `foo` is the member referenced by this using declaration |
Contributor
There was a problem hiding this comment.
I would just omit the comment here, as you effectively explain this below.
Suggested change
| * using T::foo; // `foo` is the member referenced by this using declaration | |
| * using T::m; |
Comment on lines
188
to
189
| * `getReferencedMember()` returns the member `foo` declared within the | ||
| * template type parameter `T`. |
Contributor
There was a problem hiding this comment.
Suggested change
| * `getReferencedMember()` returns the member `foo` declared within the | |
| * template type parameter `T`. | |
| * Here, `getReferencedMember()` yields the member `m` of `T`. Observe that, as `T` is not instantiated, `m` represented by a `Literal` and not a `Declaration`. |
| --- | ||
| category: feature | ||
| --- | ||
| * Added `getReferencedMember` to extract the member referenced by a `using` declaration in a templated base class. No newline at end of file |
Contributor
There was a problem hiding this comment.
Suggested change
| * Added `getReferencedMember` to extract the member referenced by a `using` declaration in a templated base class. | |
| * Added a predicate `getReferencedMember` to `UsingDeclarationEntry`, which yields a member depending on a type template parameter. |
a0dbe0e to
39469a2
Compare
jketema
reviewed
Jun 3, 2025
39469a2 to
10fb806
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.