C++: Specify GNU version on min/max test #19606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `<?` and `>?` operators where removed in g++ in version 4.3, and the latest version of our our frontend enforces this through a version check. Hence, to keep the test working, we not to explicitly specify a version.
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the min/max operator test to run under GNU C++ 4.2.0 so that the deprecated <?/>? operators are still recognized by the extractor.
- Adds a semmle-extractor option to force
--gnu_version 40200in the test. - Adjusts the expected spans for
<?and>?in the updated file.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cpp/ql/test/library-tests/exprs/min_max/test.cpp | Added extractor comment to specify GNU version 4.2.0. |
| cpp/ql/test/library-tests/exprs/min_max/expr.expected | Updated expected operator spans for <? and >?. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
<?and>?operators where removed in g++ in version 4.3, and the latest version of our our frontend enforces this through a version check. Hence, to keep the test working, we not to explicitly specify a version.