Java: Remove java/deprecated-call from the Code Quality suite. #19843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Removes the java/deprecated-call query from the Code Quality suites and updates related metadata.
- Drop the
qualitytag from theAvoidDeprecatedCallableAccess.qlmetadata. - Remove references to the deprecated query in both integration-test expectation files.
- Keep test numbering and other entries unchanged.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| java/ql/src/Advisory/Deprecated Code/AvoidDeprecatedCallableAccess.ql | Removed the quality tag from the @tags list |
| java/ql/integration-tests/java/query-suite/java-code-quality.qls.expected | Deleted the line excluding the deprecated query |
| java/ql/integration-tests/java/query-suite/java-code-quality-extended.qls.expected | Deleted the line excluding the deprecated query |
owen-mc
approved these changes
Jun 23, 2025
|
It's probably worth referencing the original PR where this query was added to the code quality suite, to make it easier to find this PR in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like this query might produce a lot more results for BMN databases compared to traced databases. Excluding it from the Code Quality suite for now.
Follow up of #19799