Thanks to visit codestin.com
Credit goes to github.com

Skip to content

C++: Support more complex 16-bit float types #19862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025
Merged

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Jun 24, 2025

No description provided.

@jketema jketema force-pushed the complex branch 2 times, most recently from 4159bce to 2843a59 Compare June 24, 2025 09:46
Comment on lines +339 to +350
<e>
<k>@complex_fp16</k>
<v>124</v>
</e>
<e>
<k>@complex_std_bfloat16</k>
<v>124</v>
</e>
<e>
<k>@complex_std_float16</k>
<v>124</v>
</e>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I just hacked this in, as stats file generation is currently broken. I do a proper update once that is fixed.

@jketema jketema marked this pull request as ready for review June 24, 2025 10:30
@jketema jketema requested a review from a team as a code owner June 24, 2025 10:30
@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jun 24, 2025
Copy link
Contributor

@andersfugmann andersfugmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM.

Copy link
Contributor

@IdrissRio IdrissRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment otherwise LGTM

@andersfugmann
Copy link
Contributor

Approving - assuming this will not merge before checks are green :-)

@jketema jketema merged commit 9a83005 into github:main Jun 24, 2025
15 of 16 checks passed
@jketema jketema deleted the complex branch June 24, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants