Codegen: use one generated test file per directory #19874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This collapses all generated test QL sources into a single one per directory, using query predicates to run the different tests. This should improve the time required to run generated tests.
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
hvitved
reviewed
Jun 25, 2025
| where | ||
| toBeTested(x) and | ||
| not x.isUnknown() and | ||
| getNumberOfArgs = x.getNumberOfArgs() |
There was a problem hiding this comment.
The new test does not output getNumberOfArgs; is that deliberate?
There was a problem hiding this comment.
yes, as the entire list of args is in the same expected file, so I think that information is redundant, and reducing the number of columns helps readability
There was a problem hiding this comment.
same goes for has... for optional properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This collapses all generated test QL sources into a single one per directory, using query predicates to run the different tests.
This should improve the time required to run generated tests.