Go: Avoid using deprecated class #19882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the deprecated DeclaredType cast in getBaseType() with the new DeclaredTypeEntity, ensuring no use of the old class remains in the Go library.
- Updated the cast in
getBaseType()fromDeclaredTypetoDeclaredTypeEntity. - Reformatted the method body to block style.
Comments suppressed due to low confidence (2)
go/ql/lib/semmle/go/Types.qll:1048
- [nitpick] Consider adding a unit test to verify that
getBaseType()behaves correctly withDeclaredTypeEntityand that unchanged behavior remains for external-package types.
result = this.getEntity().(DeclaredTypeEntity).getSpec().getTypeExpr().getType()
go/ql/lib/semmle/go/Types.qll:1048
- Ensure that
DeclaredTypeEntityis properly imported or fully qualified so that the cast compiles successfully.
result = this.getEntity().(DeclaredTypeEntity).getSpec().getTypeExpr().getType()
jcogs33
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go: Improve two class names and add some helper predicates and Go: fix DefinedType.getBaseType got merged in quick succession, without rerunning CI. One deprecated a class and the other introduced a new use of it. This means that the CI job checking that all queries compile is not happy. This PR fixes the issue by updating the new use of the deprecated class to use the replacement class instead.