Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Sep 9, 2025

In this PR we add most medium precision queries to the codeql-quality-extended suite, with the exception of

  • The java/undocumented-* queries as they produce a massive amount of results (missing documentation queries have also been excluded for other languages).

DCA looks good.

  • The performance when adding the queries looks acceptable (adding medium precision queries adds to 10% to the analysis time compared to only running queries with precision very-high and high).

@github-actions github-actions bot added the Java label Sep 9, 2025
@michaelnebel michaelnebel force-pushed the java/code-quality-extended branch from 2c5fae1 to 0793259 Compare September 10, 2025 14:16
@michaelnebel michaelnebel changed the title Java: Add all medium precision queries to the code-quality-extended suite. Java: Add many medium precision queries to the code-quality-extended suite. Sep 10, 2025
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Sep 11, 2025
@michaelnebel michaelnebel marked this pull request as ready for review September 11, 2025 07:14
@michaelnebel michaelnebel requested a review from a team as a code owner September 11, 2025 07:14
@Copilot Copilot AI review requested due to automatic review settings September 11, 2025 07:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds most medium precision queries to the codeql-quality-extended suite for Java, excluding undocumented-* queries that would produce excessive results. The changes update query tags to include the quality tag and adjust related tags for consistency across queries being added to the extended suite.

  • Updates tag structure for medium precision queries to include quality tag
  • Modifies various tag combinations to ensure consistency with extended suite requirements
  • Updates expected test files to reflect the inclusion of these queries in the extended suite

Reviewed Changes

Copilot reviewed 67 out of 67 changed files in this pull request and generated no comments.

File Description
Multiple .ql files Updated query metadata tags to include quality and adjust other tags for extended suite inclusion
not_included_in_qls.expected Removed entries for queries now included in the extended suite
java-code-quality-extended.qls.expected Added entries for the new medium precision queries included in the extended suite

@michaelnebel michaelnebel changed the title Java: Add many medium precision queries to the code-quality-extended suite. Java: Add most medium precision queries to the code-quality-extended suite. Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Java no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant