Thanks to visit codestin.com
Credit goes to github.com

Skip to content

C#: Data-flow pruning based on call contexts #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calumgrant merged 2 commits into from
Oct 21, 2019
Merged

C#: Data-flow pruning based on call contexts #2139

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
853cbd8
C#: Add dataflow tests exhibiting missing call-context based pruning
hvitved Oct 16, 2019
c57015a
C#: Data-flow pruning based on call contexts
hvitved Oct 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
C#: Add dataflow tests exhibiting missing call-context based pruning
  • Loading branch information
@hvitved
hvitved committed Oct 16, 2019
commit 853cbd87285d8cbe7dfd52e47243cbe890e78518
220 changes: 220 additions & 0 deletions csharp/ql/test/library-tests/dataflow/call-sensitivity/CallSensitivityFlow.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,220 @@
public class A
{
public static void Sink(object o)
{
}

public object FlowThrough(object o, bool cond)
{
if (cond)
{
return o;
}
else
{
return null;
}
}

public void CallSinkIfTrue(object o, bool cond)
{
if (cond)
{
Sink(o);
}
}

public void CallSinkIfFalse(object o, bool cond)
{
if (!cond)
{
Sink(o);
}
}

public void CallSinkFromLoop(object o, bool cond)
{
while (cond)
{
Sink(o);
}
}

public void LocalCallSensitivity(object o, bool c)
{
object o1 = o;
object o2 = null;
if (c)
{
object tmp = o1;
o2 = 1 == 1 ? (tmp) : (tmp);
}
object o3 = o2;
Sink(o3);
}

public void LocalCallSensitivity2(object o, bool b, bool c)
{
object o1 = o;
object o2 = null;
if (b || c)
{
object tmp = o1;
o2 = 1 == 1 ? (tmp) : (tmp);
}
object o3 = o2;
Sink(o3);
}

public void M1()
{
// should not exhibit flow
CallSinkIfTrue(new object(), false);
CallSinkIfFalse(new object(), true);
CallSinkFromLoop(new object(), false);
LocalCallSensitivity(new object(), false);
Sink(FlowThrough(new object(), false));
// should exhibit flow
CallSinkIfTrue(new object(), true);
CallSinkIfFalse(new object(), false);
CallSinkFromLoop(new object(), true);
LocalCallSensitivity(new object(), true);
LocalCallSensitivity2(new object(), true, true);
LocalCallSensitivity2(new object(), false, true);
LocalCallSensitivity2(new object(), true, false);
Sink(FlowThrough(new object(), true));
// expected false positive
LocalCallSensitivity2(new object(), false, false);
}

public void M2()
{
bool t = true;
bool f = false;
// should not exhibit flow
CallSinkIfTrue(new object(), f);
CallSinkIfFalse(new object(), t);
CallSinkFromLoop(new object(), f);
LocalCallSensitivity(new object(), f);
Sink(FlowThrough(new object(), f));
// should exhibit flow
CallSinkIfTrue(new object(), t);
CallSinkIfFalse(new object(), f);
CallSinkFromLoop(new object(), t);
LocalCallSensitivity(new object(), t);
Sink(FlowThrough(new object(), t));
}

public void M3(InterfaceA b)
{
bool t = true;
bool f = false;
// should not exhibit flow
b.CallSinkIfTrue(new object(), f);
b.CallSinkIfFalse(new object(), t);
b.LocalCallSensitivity(new object(), f);
// should exhibit flow
b.CallSinkIfTrue(new object(), t);
b.CallSinkIfFalse(new object(), f);
b.LocalCallSensitivity(new object(), t);
}

class B : InterfaceA
{
public void CallSinkIfTrue(object o, bool cond)
{
if (cond)
{
Sink(o);
}
}


public void CallSinkIfFalse(object o, bool cond)
{
if (!cond)
{
Sink(o);
}
}


public void LocalCallSensitivity(object o, bool c)
{
object o1 = o;
object o2 = null;
if (c)
{
object tmp = o1;
o2 = 1 == 1 ? (tmp) : (tmp);
}
object o3 = o2;
Sink(o3);
}
}
}

public class A2
{

public static void Sink(object o)
{
}

public void M()
{

}

public void Callsite(InterfaceB intF)
{
B b = new B();
// in both possible implementations of foo, this callsite is relevant
// in IntA, it improves virtual dispatch,
// and in IntB, it improves the dataflow analysis.
intF.Foo(b, new object(), false);
}

private class B : A2
{
public void M()
{

}
}

private class IntA : InterfaceB
{

public void Foo(A2 obj, object o, bool cond)
{
obj.M();
Sink(o);
}
}

private class IntB : InterfaceB
{

public void Foo(A2 obj, object o, bool cond)
{
if (cond)
{
Sink(o);
}
}
}

}

public interface InterfaceA
{
void CallSinkIfTrue(object o, bool cond);
void CallSinkIfFalse(object o, bool cond);
void LocalCallSensitivity(object o, bool c);
}

public interface InterfaceB
{
void Foo(A2 a, object o, bool cond);
}
Loading