Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Python: Add LDAP Injection query #5443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RasmusWL merged 35 commits into from
May 26, 2021
Merged

Python: Add LDAP Injection query #5443

Changes from 1 commit
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
799d509
Upload LDAP Injection query, qhelp and tests
jorgectf Mar 18, 2021
719b48c
Move to experimental folder
jorgectf Mar 18, 2021
95a1dae
Precision warn and Remove CWE reference
jorgectf Mar 18, 2021
85ec82a
Refactor in progress
jorgectf Mar 28, 2021
ad36bea
Refactor LDAP3 stuff (untested)
jorgectf Mar 29, 2021
8223539
Add a test without attributes
jorgectf Mar 29, 2021
3cda2e5
Polish up ldap3 tests
jorgectf Mar 29, 2021
8faafb6
Update Sink
jorgectf Mar 30, 2021
4328ff3
Remove attrs feature
jorgectf Mar 31, 2021
9b43031
Improve Sanitizer calls
jorgectf Mar 31, 2021
1bcb9cd
Simplify query
jorgectf Apr 6, 2021
33423ea
Optimize calls
jorgectf Apr 7, 2021
a1850dd
Change LDAP config (qll) filename
jorgectf Apr 8, 2021
8661cb0
Polish LDAP3Query
jorgectf Apr 8, 2021
7296879
Polish tests
jorgectf Apr 8, 2021
3c1ca72
Improve qhelp
jorgectf Apr 8, 2021
1554f4f
Create qhelp examples
jorgectf Apr 8, 2021
95bfdc4
Move tests to /test
jorgectf Apr 8, 2021
4f85de8
Add qlref
jorgectf Apr 8, 2021
7819d1a
Generate .expected
jorgectf Apr 8, 2021
b405c67
Add qhelp last newline
jorgectf Apr 8, 2021
82f47f8
Polish metadata
jorgectf Apr 8, 2021
cd75433
Fix qhelp examples extension
jorgectf Apr 8, 2021
a2e8d88
Write documentation
jorgectf Apr 8, 2021
b020ea6
Polish documentation
jorgectf Apr 8, 2021
1c34230
Fix documentation typo
jorgectf Apr 8, 2021
c2b96b3
Add documentation to main classes' functions.
jorgectf May 7, 2021
34b8af3
Move structure to LDAP.qll
jorgectf May 7, 2021
6159fbe
Update functions naming
jorgectf May 7, 2021
2ad72ad
Add LDAP framework entry in Frameworks.qll
jorgectf May 7, 2021
8665747
Update sink and sanitizer to match new naming
jorgectf May 8, 2021
9e9678b
Apply documentation suggestions
jorgectf May 21, 2021
37d6ff7
Update tests and .expected
jorgectf May 21, 2021
d5f2846
Merge branch 'main' into jorgectf/python/ldapInjection
RasmusWL May 26, 2021
f807c2f
Python: autoformat
RasmusWL May 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve Sanitizer calls
  • Loading branch information
@jorgectf
jorgectf committed Mar 31, 2021
commit 9b430310b4ecd9535191262249d889d0b9306025
44 changes: 16 additions & 28 deletions python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,27 +46,21 @@ private module LDAP {
override string getLDAPPart() { result = ldapPart }
}

private class LDAP2EscapeDN extends DataFlow::CallCfgNode, LDAPEscape::Range {
DataFlow::Node escapeNode;

LDAP2EscapeDN() {
this = API::moduleImport("ldap").getMember("dn").getMember("escape_dn_chars").getACall() and
escapeNode = this.getArg(0)
private class LDAP2EscapeDNCall extends DataFlow::CallCfgNode, LDAPEscape::Range {
LDAP2EscapeDNCall() {
this = API::moduleImport("ldap").getMember("dn").getMember("escape_dn_chars").getACall()
}

override DataFlow::Node getEscapeNode() { result = escapeNode }
override DataFlow::Node getEscapeNode() { result = this.getArg(0) }
}

private class LDAP2EscapeFilter extends DataFlow::CallCfgNode, LDAPEscape::Range {
DataFlow::Node escapeNode;

LDAP2EscapeFilter() {
private class LDAP2EscapeFilterCall extends DataFlow::CallCfgNode, LDAPEscape::Range {
LDAP2EscapeFilterCall() {
this =
API::moduleImport("ldap").getMember("filter").getMember("escape_filter_chars").getACall() and
escapeNode = this.getArg(0)
API::moduleImport("ldap").getMember("filter").getMember("escape_filter_chars").getACall()
}

override DataFlow::Node getEscapeNode() { result = escapeNode }
override DataFlow::Node getEscapeNode() { result = this.getArg(0) }
}
}

Expand Down Expand Up @@ -100,36 +94,30 @@ private module LDAP {
override string getLDAPPart() { result = ldapPart }
}

private class LDAP3EscapeDN extends DataFlow::CallCfgNode, LDAPEscape::Range {
DataFlow::Node escapeNode;

LDAP3EscapeDN() {
private class LDAP3EscapeDNCall extends DataFlow::CallCfgNode, LDAPEscape::Range {
LDAP3EscapeDNCall() {
this =
API::moduleImport("ldap3")
.getMember("utils")
.getMember("dn")
.getMember("escape_rdn")
.getACall() and
escapeNode = this.getArg(0)
.getACall()
}

override DataFlow::Node getEscapeNode() { result = escapeNode }
override DataFlow::Node getEscapeNode() { result = this.getArg(0) }
}

private class LDAP3EscapeFilter extends DataFlow::CallCfgNode, LDAPEscape::Range {
DataFlow::Node escapeNode;

LDAP3EscapeFilter() {
private class LDAP3EscapeFilterCall extends DataFlow::CallCfgNode, LDAPEscape::Range {
LDAP3EscapeFilterCall() {
this =
API::moduleImport("ldap3")
.getMember("utils")
.getMember("conv")
.getMember("escape_filter_chars")
.getACall() and
escapeNode = this.getArg(0)
.getACall()
}

override DataFlow::Node getEscapeNode() { result = escapeNode }
override DataFlow::Node getEscapeNode() { result = this.getArg(0) }
}
}
}