Make PR checks compatible with the latest version of the ubuntu-latest runner image
#1330
Conversation
fff7f04 to
69d3a56
Compare
Build tracing using CLIs before 2.7.3 no longer works with the most recent update to the `ubuntu-22.04` runner image. With this new logic, we can remove the workarounds around testing `windows-2019` and `windows-2022`.
69d3a56 to
d105e6f
Compare
ubuntu-latest runner image
ubuntu-latest runner imageubuntu-latest runner image
d105e6f to
8fdcf29
Compare
8fdcf29 to
4ed5abe
Compare
| @@ -21,7 +21,7 @@ jobs: | |||
| strategy: | |||
| matrix: | |||
| include: | |||
| - os: ubuntu-latest | |||
| - os: ubuntu-20.04 | |||
| version: stable-20210809 | |||
| - os: ubuntu-latest | |||
There was a problem hiding this comment.
Should this be changed to ubuntu-22.04? Or maybe above should be changed to ubuntu-latest (I think I'd prefer this). In general, we should not have to specify 22.04 (using latest instead) and when the next version of ubuntu comes out, some of our tests may break, but that's a good thing since we will be aware of this and can fix proactively.
There was a problem hiding this comment.
Could you clarify what you mean by "Or maybe above should be changed to ubuntu-latest"?
There was a problem hiding this comment.
Sorry...that wasn't very clear. I am suggesting that everywhere there is ubuntu-22.04 now, we should change to ubuntu-latest. This was when ubuntu-latest is changed again, we will know if anything is broken.
In particular, I was thinking here:
and here:
And in other places in .github/workflows/python-deps.yml.
There was a problem hiding this comment.
Ah, I see what you mean now. I think you're generally right, but my hesitancy for python-deps.yml specifically is that these jobs were previously testing against both ubuntu-20.04 and ubuntu-22.04, and the migration of ubuntu-latest to ubuntu-22.04 isn't fully rolled out. It would be possible for ubuntu-latest to start pointing to ubuntu-20.04 again before the rollout completes, which would cause us to silently lose test coverage here. I'd be in favour to switching to ubuntu-latest once the rollout completes.
There was a problem hiding this comment.
I'd be in favour to switching to ubuntu-latest once the rollout completes.
Sure. I'm guessing you're tracking this in https://github.com/github/codeql-core/issues/2909?
There was a problem hiding this comment.
This is fine as long as we use https://github.com/github/codeql-core/issues/2909 to remember to move to ubuntu-latest when 22.04 is fully rolled out.
This PR updates the PR checks to handle the recent update to the
ubuntu-latestrunner image. This is being moved over to Ubuntu 22.04, which is only compatible with CodeQL CLI 2.7.3 and later. Some of our PR checks use very old CLIs, and this PR updates them to run on theubuntu-20.04image instead.Planned work:
-latestimage changes.Merge / deployment checklist