Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use Swift version 5.7 in PR checks #1387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 22, 2022
Merged

Conversation

henrymercer
Copy link
Contributor

@henrymercer henrymercer commented Nov 22, 2022

The version installed in the latest runner image, 5.7.1, is not yet supported.

cc @AlexDenisov

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

The version installed in the latest runner image, 5.7.1, is not yet
supported.
@henrymercer henrymercer force-pushed the henrymercer/fix-swift-version branch from fa52443 to b6e17a6 Compare November 22, 2022 11:31
@henrymercer henrymercer marked this pull request as ready for review November 22, 2022 12:40
@henrymercer henrymercer requested a review from a team as a code owner November 22, 2022 12:40
angelapwen
angelapwen previously approved these changes Nov 22, 2022
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

I wonder if I should also include this step in the CodeQL Action integration test on the CLI-side (just adding the check for Swift here https://github.com/github/semmle-code/pull/44368/files#)

@henrymercer
Copy link
Contributor Author

I wonder if I should also include this step in the CodeQL Action integration test on the CLI-side (just adding the check for Swift here https://github.com/github/semmle-code/pull/44368/files#)

👍 That makes sense to me

angelapwen
angelapwen previously approved these changes Nov 22, 2022
@henrymercer henrymercer merged commit def4f60 into main Nov 22, 2022
@henrymercer henrymercer deleted the henrymercer/fix-swift-version branch November 22, 2022 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants