Add workload_run_attempt to analysis upload
#1658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had duplicated the logic to check `GITHUB_RUN_ID`. We now call the `getWorkflowRunID()` method for the status report upload method, and move the logic for the run attempt to `getWorkflowRunAttempt()`
Because we already throw an error if the ID or attempt aren't numbers, we don't have to allow `undefined` values into the payload.
aeisenberg
reviewed
Apr 25, 2023
src/workflow.ts
Outdated
| ); | ||
| if (Number.isNaN(workflowRunAttempt)) { | ||
| throw new Error( | ||
| "GITHUB_RUN_ATTEMPT must define a non NaN workflow run attempt" |
There was a problem hiding this comment.
Maybe include the original value here so we can see what the error was.
There was a problem hiding this comment.
Also, (minor) maybe make sure that the value is > 0?
There was a problem hiding this comment.
Done. It wasn't clear to me if GITHUB_RUN_ID could possibly be 0, so I only checked for negative values 🤔 GITHUB_RUN_ATTEMPT clearly states that the value should begin at 1: https://docs.github.com/en/actions/learn-github-actions/variables#default-environment-variables
aeisenberg
approved these changes
Apr 26, 2023
6 tasks
angelapwen
added a commit
that referenced
this pull request
Apr 26, 2023
* Update changelog and version after v2.3.0 * Update checked-in dependencies * Throw full error for CLI bundle download (#1657) * Add `workload_run_attempt` to analysis upload (#1658) * Refactor status report upload logic Previously we had duplicated the logic to check `GITHUB_RUN_ID`. We now call the `getWorkflowRunID()` method for the status report upload method, and move the logic for the run attempt to `getWorkflowRunAttempt()` * Add `workflow_run_attempt` to analysis payload * Stop allowing `undefined` run IDs and attempts Because we already throw an error if the ID or attempt aren't numbers, we don't have to allow `undefined` values into the payload. * Update changelog for v2.3.1 --------- Co-authored-by: github-actions[bot] <[email protected]> Co-authored-by: Chuan-kai Lin <[email protected]> Co-authored-by: Angela P Wen <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we began sending the
workflow_run_attemptfield to our status reports. We also want to send it to the analysis upload API 😄This PR does a bit of refactoring so that
workflow_run_idandworkflow_run_attemptare populated the same across the status report and analysis payloads.Merge / deployment checklist