Simplify CodeQL setup now that the last two releases have semver bundles #1761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default version feature flags will now always point to a CLI version with a semantically versioned bundle, so we can find the GitHub Release directly from the CLI version.
Previously, this was useful for discriminating between different `CodeQLDefaultVersion` instances. However now all instances return a tag name.
src/setup-codeql.ts
Fixed
| if (!codeqlFolder && (cliVersion || tagName)) { | ||
| if (cliVersion || tagName) { | ||
| if (!codeqlFolder && tagName) { | ||
| if (tagName) { |
Check warning
Code scanning / CodeQL
Useless conditional
angelapwen
approved these changes
Jul 7, 2023
| url = await getCodeQLBundleDownloadURL( | ||
| tagName, | ||
| tagName!, |
There was a problem hiding this comment.
TIL about this operator 🤯
There was a problem hiding this comment.
It's not the best sign when you have to use it, but here it didn't seem worth refactoring the types :)
This was referenced Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the last two CLI versions have semantically versioned bundles, we no longer need to handle the case where the default version feature flags specify a version that doesn't have a semantically versioned bundle. As a result, we can reduce the complexity of the setup code!
Merge / deployment checklist