Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump the npm group with 2 updates #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 25, 2023
Merged

Bump the npm group with 2 updates #1798

merged 5 commits into from
Jul 25, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 24, 2023

Bumps the npm group with 2 updates: @schemastore/package and eslint-plugin-github.

Updates @schemastore/package from 0.0.8 to 0.0.10

Commits

Updates eslint-plugin-github from 4.9.0 to 4.9.2

Release notes

Sourced from eslint-plugin-github's releases.

v4.9.2

What's Changed

Full Changelog: github/eslint-plugin-github@v4.9.1...v4.9.2

v4.9.1

Bug fixes

This release includes bug fixes for a few accessibility rules including: a11y-aria-role-supports-props, a11y-no-title-attribute, and jsx-a11y/no-interactive-element-to-noninteractive-role.

What's Changed

New Contributors

Full Changelog: github/eslint-plugin-github@v4.9.0...v4.9.1

Commits
  • cd17c09 Merge pull request #466 from github/kh-use-literal-prop-for-class
  • c2ea115 Use literal prop
  • dd3cba1 Add failing test case
  • 0c0441f Merge pull request #463 from github/kh-use-prop-value
  • 8c5f809 Merge branch 'main' into kh-use-prop-value
  • 125ac51 Merge pull request #464 from github/fix-a11y-no-title-attribute
  • ee9e16d lint
  • 29ead03 add test
  • b05b0cb Do not look up as prop
  • 7036141 Add logic to check for presence of attribute
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@dependabot
Bump the npm group with 2 updates
601c5ba 
Bumps the npm group with 2 updates: [@schemastore/package](https://github.com/ffflorian/schemastore-updater) and [eslint-plugin-github](https://github.com/github/eslint-plugin-github).


Updates `@schemastore/package` from 0.0.8 to 0.0.10
- [Release notes](https://github.com/ffflorian/schemastore-updater/releases)
- [Commits](https://github.com/ffflorian/schemastore-updater/commits)

Updates `eslint-plugin-github` from 4.9.0 to 4.9.2
- [Release notes](https://github.com/github/eslint-plugin-github/releases)
- [Commits](github/eslint-plugin-github@v4.9.0...v4.9.2)

---
updated-dependencies:
- dependency-name: "@schemastore/package"
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: npm
- dependency-name: eslint-plugin-github
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: npm
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner July 24, 2023 17:12
@dependabot dependabot bot added the Update dependencies Trigger PR workflow to update dependencies label Jul 24, 2023
@github-actions github-actions bot removed the Update dependencies Trigger PR workflow to update dependencies label Jul 24, 2023
@angelapwen angelapwen closed this Jul 25, 2023
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Jul 25, 2023

This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests.

@angelapwen angelapwen reopened this Jul 25, 2023
@angelapwen angelapwen force-pushed the dependabot/npm_and_yarn/npm-7f457b68a6 branch from 8bd4224 to b16296b Compare July 25, 2023 08:34
@angelapwen
Copy link
Contributor

@github/codeql-action-reviewers could I get another set of 👀 s to approve as I pushed the last commit? Thank you!

@angelapwen angelapwen enabled auto-merge (squash) July 25, 2023 11:43
henrymercer
henrymercer reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that's a lot of commas — I'm not sure I love them, but I think they're probably an improvement overall when it comes to viewing diffs. Given the huge diff in source code, I'd strongly consider creating a .git-blame-ignore-revs file adding the commit where you update the source code, and making sure we merge this with a merge commit.

Edit: We can also remove the ignore statement for @schemastore/[email protected] from the Dependabot file, since 0.0.10 is compatible and we've upgraded to it here.

@henrymercer henrymercer disabled auto-merge July 25, 2023 14:54
@angelapwen
Copy link
Contributor

Wow that's a lot of commas — I'm not sure I love them, but I think they're probably an improvement overall when it comes to viewing diffs.

Yeah, I'm not sure I love all of them either, but agreed that on balance they're an improvement.

Given the huge diff in source code, I'd strongly consider creating a .git-blame-ignore-revs file adding the commit where you update the source code, and making sure we merge this with a merge commit.

TIL about that 🤯 done — and will update to merge w/ merge commit

Edit: We can also remove the ignore statement for @schemastore/[email protected] from the Dependabot file, since 0.0.10 is compatible and we've upgraded to it here.

Done!

@angelapwen angelapwen enabled auto-merge July 25, 2023 16:02
henrymercer
henrymercer approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@angelapwen angelapwen disabled auto-merge July 25, 2023 16:13
@angelapwen angelapwen enabled auto-merge July 25, 2023 16:15
@angelapwen angelapwen merged commit c57b27e into main Jul 25, 2023
@angelapwen angelapwen deleted the dependabot/npm_and_yarn/npm-7f457b68a6 branch July 25, 2023 16:34
@github-actions github-actions bot mentioned this pull request Jul 26, 2023
Merged
6 tasks
@aliscco aliscco mentioned this pull request May 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelapwen @henrymercer