Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix name of Python stdlib extraction feature flag #2550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2024
Merged

Fix name of Python stdlib extraction feature flag #2550

merged 2 commits into from
Oct 17, 2024

Conversation

henrymercer
Copy link
Contributor

I missed this in my initial review of #2536. Also add a unit test to prevent us from making this mistake again.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@henrymercer henrymercer requested a review from a team as a code owner October 17, 2024 10:27
yoff
yoff previously approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this. I think it is great that you added a test for this also 💪 (If I misunderstood the naming convention, others might too.)

NlightNFotis
NlightNFotis previously approved these changes Oct 17, 2024
View reviewed changes
@henrymercer henrymercer dismissed stale reviews from NlightNFotis and yoff via 5d314b7 October 17, 2024 11:05
@henrymercer henrymercer requested a review from yoff October 17, 2024 11:06
yoff
yoff approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This currently has little effect due to the way the Python extractor interprets environment variables, but it will allow us to make a more standard interpretation in the future. (This is not unlikely, if we start moving to extractor options.)

@henrymercer henrymercer enabled auto-merge October 17, 2024 11:10
@henrymercer henrymercer merged commit af56b04 into main Oct 17, 2024
275 checks passed
@henrymercer henrymercer deleted the henrymercer/fix-ff-name branch October 17, 2024 11:36
This was referenced Oct 22, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoff yoff yoff approved these changes

@NlightNFotis NlightNFotis NlightNFotis left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@henrymercer @yoff @NlightNFotis