Add actions-specific telemetry fields #2874
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds new telemetry fields to the QueriesStatusReport interface so that actions-specific query execution and result interpretation durations can be captured and sent to the telemetry processor.
- Adds the field analyze_builtin_queries_actions_duration_ms with updated JSDoc comments.
- Adds the field interpret_results_actions_duration_ms with corresponding documentation updates.
Comments suppressed due to low confidence (2)
src/analyze.ts:51
- Consider adding unit tests that verify the telemetry event includes the new actions-specific query duration field.
analyze_builtin_queries_actions_duration_ms?: number;
src/analyze.ts:109
- Consider adding tests to validate that the result interpretation duration for actions is correctly captured and propagated to telemetry.
interpret_results_actions_duration_ms?: number;
b9969e5 to
3ca9a88
Compare
adityasharad
approved these changes
Apr 30, 2025
henrymercer
approved these changes
Apr 30, 2025
|
Thanks for the reviews. The failures look transient. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures we are sending proper events to our telemetry processor when we run actions queries.
Merge / deployment checklist