Do not fail diff informed analyses when analyze is run twice in the same job #2876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These relied on the RUNNER_TEMP environment variable that does not necessarily exist when running locally.
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that running the analyze action multiple times in the same job does not fail by:
- Changing the default cache config from a static constant to a lazily computed function
- Making the diff-range extension pack directory creation idempotent with
recursive: true
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/dependency-caching.ts | Replaced static CODEQL_DEFAULT_CACHE_CONFIG with getDefaultCacheConfig() to defer env‑based values |
| src/analyze.ts | Made fs.mkdirSync recursive when creating the diff-range dir |
| lib/dependency-caching.js | Mirrored the switch to getDefaultCacheConfig() in compiled JS |
| lib/analyze.js | Mirrored use of fs.mkdirSync(..., { recursive: true }) in JS |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tolerate the diff range extension pack directory already existing and overwrite it, to avoid failing in jobs that call
analyzemore than once.Also defer the computation of the dependency caching default cache config to avoid getting the value of the
RUNNER_TEMPenvironment variable before it can be overridden by test logic.And finally disable diff-informed analyses within the config parsing tests, since these tests do not account for the additional query filter added by diff-informed analyses.
Merge / deployment checklist