-
Notifications
You must be signed in to change notification settings - Fork 363
Merge main into releases/v3 #2926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Bumps the npm group with 5 updates: | Package | From | To | | --- | --- | --- | | [octokit](https://github.com/octokit/octokit.js) | `5.0.2` | `5.0.3` | | [@eslint/js](https://github.com/eslint/eslint/tree/HEAD/packages/js) | `9.27.0` | `9.28.0` | | [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) | `8.32.1` | `8.33.1` | | [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) | `8.32.1` | `8.33.1` | | [nock](https://github.com/nock/nock) | `14.0.4` | `14.0.5` | Updates `octokit` from 5.0.2 to 5.0.3 - [Release notes](https://github.com/octokit/octokit.js/releases) - [Commits](octokit/octokit.js@v5.0.2...v5.0.3) Updates `@eslint/js` from 9.27.0 to 9.28.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint/eslint/commits/v9.28.0/packages/js) Updates `@typescript-eslint/eslint-plugin` from 8.32.1 to 8.33.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.33.1/packages/eslint-plugin) Updates `@typescript-eslint/parser` from 8.32.1 to 8.33.1 - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v8.33.1/packages/parser) Updates `nock` from 14.0.4 to 14.0.5 - [Release notes](https://github.com/nock/nock/releases) - [Changelog](https://github.com/nock/nock/blob/main/CHANGELOG.md) - [Commits](nock/nock@v14.0.4...v14.0.5) --- updated-dependencies: - dependency-name: octokit dependency-version: 5.0.3 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: npm - dependency-name: "@eslint/js" dependency-version: 9.28.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/eslint-plugin" dependency-version: 8.33.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: "@typescript-eslint/parser" dependency-version: 8.33.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm - dependency-name: nock dependency-version: 14.0.5 dependency-type: direct:development update-type: version-update:semver-patch dependency-group: npm ... Signed-off-by: dependabot[bot] <[email protected]>
Mergeback v3.28.19 refs/heads/releases/v3 into main
Fix backslashes being accepted by `sanitizeArtifactName`
…cdc43f build(deps): bump the npm group with 5 updates
…2.16.6 Bump minimum CodeQL version to 2.16.6
Update default bundle to 2.22.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR merges recent main
changes into the releases/v3
branch, updating default versions, streamlining tracing and initialization logic, and cleaning up related tests.
- Bumped default CodeQL bundle and CLI versions (2.22.0) in
defaults.json
and updated the changelog. - Simplified tracer configuration by removing explicit
CODEQL_RUNNER
injection and deprecated tests. - Removed
printPathFiltersWarning
and migratedinitConfig
to use consolidated logging groups.
Reviewed Changes
Copilot reviewed 1618 out of 1618 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
lib/defaults.json | Updated bundle/CLI versions and prior version fields. |
CHANGELOG.md | Added new 3.29.0 entry reflecting version bumps. |
lib/tracer-config.js | Removed runner‐injection logic and unused feature checks. |
lib/tracer-config.test.js | Deleted deprecated assertions; renamed test. |
lib/init.js | Removed printPathFiltersWarning , migrated to withGroupAsync . |
lib/init-action.js | Consolidated debug artifact variables and suppressed outdated warnings. |
lib/debug-artifacts.js | Tightened regex in sanitizeArtifactName to strip backslashes. |
lib/codeql.js | Bumped minimum CodeQL version and removed build-mode feature guards. |
lib/autobuild.js | Removed unsupported feature checks around build modes. |
lib/analyze.js | Dropped redundant feature checks in extraction logic. |
Comments suppressed due to low confidence (3)
lib/tracer-config.test.js:62
- The renamed test no longer verifies that the returned environment includes the expected runner path for each platform. Consider restoring explicit assertions to validate the full
env
object whenstart-tracing.json
is present.
(0, ava_1.default)("getCombinedTracerConfig", async (t) => {
lib/tracer-config.js:49
- [nitpick] The comment mentions checking CLI support for
trace-command --build-mode
, but the corresponding feature check was removed. Update or remove this comment to avoid confusion.
// If the CLI supports `trace-command` with a `--build-mode`, we'll use direct tracing instead of
lib/init.js:43
- The
languages
import is no longer used after removingprintPathFiltersWarning
. Consider deleting this import to clean up unused code.
const languages_1 = require("./languages");
Merging e879928 into
releases/v3
.Conductor for this PR is @cklin.
Contains the following pull requests:
sanitizeArtifactName
#2922 (@mbg)Please do the following:
releases/v3
branch.Create a merge commit
is selected rather thanSquash and merge
orRebase and merge
.