Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update runner building dependencies #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2021

Conversation

edoardopirovano
Copy link
Contributor

The dependencies we use when building the runner can't be automatically updated by Dependabot since they are in a package.json in a sub-folder rather than in the main one. Nonetheless, we should still occasionally update them. In particular, there is currently an alert on one of the transitive dependencies being affected by this CVE (GHSA-ww39-953v-wcq6), which I believe will be resolved by this update.

@edoardopirovano edoardopirovano requested a review from a team as a code owner July 29, 2021 10:09
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we teach Dependabot to look in the subfolder?

@edoardopirovano
Copy link
Contributor Author

Can we teach Dependabot to look in the subfolder?

I'll look into it after this PR!

@edoardopirovano edoardopirovano merged commit 833be9c into github:main Jul 29, 2021
@edoardopirovano edoardopirovano deleted the update-runner-deps branch July 29, 2021 15:15
@github-actions github-actions bot mentioned this pull request Aug 2, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants