Ensure loadApiError is caught

And add a better error message. By using `void` instead of `await`, any error thrown is not caught by surrounding try-catch blocks. I could continue to use `void` and explicitly handle any thrown errors by using `.catch`, but most likely the time savings is minimal and this makes the code more complex.
github · aeisenberg · Jan 24, 2022 · Jan 21, 2022 · Jan 21, 2022 · Jan 21, 2022
commit 752ae5743f660abf77f426071c8a73dfdf3b8a0a
@@ -66,13 +66,25 @@ export class GitHubFeatureFlags implements FeatureFlags {
         );
         return response.data;
       } catch (e) {
-        // Some feature flags, such as `ml_powered_queries_enabled` affect the produced alerts.
-        // Considering these feature flags disabled in the event of a transient error could
-        // therefore lead to alert churn. As a result, we crash if we cannot determine the value of
-        // the feature flags.
-        throw new Error(
-          `Encountered an error while trying to load feature flags: ${e}`
-        );
+        if (
+          e instanceof Error &&
+          e.message.includes("Resource not accessible by integration")
+        ) {
+          throw new Error(
+            `Resource not accessible by integration. This usually means that your ` +
+              `workflow is missing the required security-events write permissions. ` +
+              `See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions ` +
+              `for more information.`
+          );
+        } else {
+          // Some feature flags, such as `ml_powered_queries_enabled` affect the produced alerts.
+          // Considering these feature flags disabled in the event of a transient error could
+          // therefore lead to alert churn. As a result, we crash if we cannot determine the value of
+          // the feature flags.
+          throw new Error(
+            `Encountered an error while trying to load feature flags: ${e}`
+          );
+        }
       }
     };
 

@@ -143,9 +143,10 @@ async function run() {
     repositoryNwo,
     logger
   );
-  void featureFlags.preloadFeatureFlags();
 
   try {
+    await featureFlags.preloadFeatureFlags();
+
     const workflowErrors = await validateWorkflow();
 
     if (