Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix keyboard event handling during composition #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muan merged 4 commits into from
Dec 20, 2018
Merged

Fix keyboard event handling during composition #2

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e93b7a
Clear selection and return keydown event during composition
muan Dec 18, 2018
b4450a8
Add wrapping form to test default prevention
muan Dec 18, 2018
3df86d6
Support escape to clear selection and only prevent default if committed
muan Dec 18, 2018
895f19b
Use boolean instead of map because composition always ends when switc…
muan Dec 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Clear selection and return keydown event during composition 
keydown and composition events get triggered in different orders across browsers
so we can't rely on the 'mid composition' state and would need to clear
selection to prevent triggering activation unintentionally
  • Loading branch information
@muan
muan committed Dec 18, 2018
commit 0e93b7a02d32e6ba1778fa3a4a0940c8bf075ac5
19 changes: 19 additions & 0 deletions combobox-nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,18 @@
/* @flow strict */

const compositionMap = new WeakMap()

export function install(input: HTMLTextAreaElement | HTMLInputElement, list: HTMLElement): void {
input.addEventListener('compositionstart', trackComposition)
input.addEventListener('compositionend', trackComposition)
input.addEventListener('keydown', keyboardBindings)
list.addEventListener('click', commitWithElement)
}

export function uninstall(input: HTMLTextAreaElement | HTMLInputElement, list: HTMLElement): void {
input.removeAttribute('aria-activedescendant')
input.removeEventListener('compositionstart', trackComposition)
input.removeEventListener('compositionend', trackComposition)
input.removeEventListener('keydown', keyboardBindings)
list.removeEventListener('click', commitWithElement)
}
Expand All @@ -17,6 +23,7 @@ function keyboardBindings(event: KeyboardEvent) {
if (event.shiftKey || event.metaKey || event.altKey) return
const input = event.currentTarget
if (!(input instanceof HTMLTextAreaElement || input instanceof HTMLInputElement)) return
if (compositionMap.get(input)) return
const list = document.getElementById(input.getAttribute('aria-owns') || '')
if (!list) return

Expand Down Expand Up @@ -96,3 +103,15 @@ export function navigate(
}
}
}

function trackComposition(event: Event) {
const input = event.currentTarget
if (!(input instanceof HTMLTextAreaElement || input instanceof HTMLInputElement)) return
compositionMap.set(input, event.type === 'compositionstart')

const list = document.getElementById(input.getAttribute('aria-owns') || '')
if (!list) return
const target = list.querySelector('[aria-selected="true"]')
if (!target) return
target.setAttribute('aria-selected', 'false')
}