Avoid clearning selection on ctrlKey #26
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25.
Here I've also added back the tests for macos control bindings removed in 19b468f, and added a os matrix to our github action tests.
As #22 (comment) 4. listed, we are using keydown to cover some non-input keystrokes like ArrowLeft/Right/Home/End as well. Here I've added and input handler too to cover modifier keys triggered input events like shiftkey + char.