Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Avoid clearning selection on ctrlKey #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 12, 2020
Merged

Avoid clearning selection on ctrlKey #26

merged 6 commits into from
May 12, 2020

Conversation

muan
Copy link
Contributor

@muan muan commented May 11, 2020

Fixes #25.

a keydown event for the Ctrl key will fall to the default case, clearing the selection. This always makes Ctrl+P and Ctrl+N start at the beginning.

Here I've also added back the tests for macos control bindings removed in 19b468f, and added a os matrix to our github action tests.


@T-Hugs: I don't think the selection should be cleared in a keydown handler. Perhaps an input handler would be more appropriate for that.

As #22 (comment) 4. listed, we are using keydown to cover some non-input keystrokes like ArrowLeft/Right/Home/End as well. Here I've added and input handler too to cover modifier keys triggered input events like shiftkey + char.

@muan muan requested a review from a team May 11, 2020 19:52
@muan muan merged commit 4cfd57e into master May 12, 2020
@muan muan deleted the clearselection branch May 12, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ctrl key clears selection before Ctrl+N or Ctrl+P keycombo can be used
2 participants