Fix deprecation warning about fs.rmdirSync(path, { recursive: true })
#1254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25655e7 to
5043305
Compare
Logs from running this action ([example](https://github.com/github/dependabot-action/actions/runs/9784790222/job/27016465395#step:3:155)): ``` (node:1631) [DEP0147] DeprecationWarning: In future versions of Node.js, fs.rmdir(path, { recursive: true }) will be removed. Use fs.rm(path, { recursive: true }) instead (Use `node --trace-deprecation ...` to show where the warning was created) ``` Relevant docs: https://nodejs.org/api/fs.html#fsrmdirsyncpath-options This deprecation landed in Node 16.
5043305 to
ed57b42
Compare
|
I manually ran a Dependabot job and confirmed that the deprecation warning is now gone from the logs. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs from running this action
(example):
Relevant docs: https://nodejs.org/api/fs.html#fsrmdirsyncpath-options
This deprecation landed in Node 16.