Switch from PAT to federated secret for pulling ghcr images #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using a user-based PAT, but those expire every 90 days. By switching to the federated token, it gets rotated/audited by the security team, and not something we have to maintain.
jeffwidman
commented
May 16, 2025
| type: docker-registry | ||
| url: ghcr.io | ||
| username: x | ||
| password: ${{ secrets.BASE_CONTAINER_IMAGE_READER_DEPENDABOT }} |
There was a problem hiding this comment.
I moved this to the top because that's where we typically have been putting the registries key on all our files for easier skimmability...
There was a problem hiding this comment.
Pull Request Overview
Switch dependabot from a user PAT to a federated secret for GHCR image pulls, removing manual rotation and using the security-managed token.
- Introduce a top-level
registriesblock pointing at GHCR with the new federated secret - Remove the old inline
registriessection that used the PAT (DEPENDABOT_GHPR_TOKEN) - Update the secret reference to
BASE_CONTAINER_IMAGE_READER_DEPENDABOT
kbukum1
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using a user-based PAT, but those expire every 90 days.
By switching to the federated token, it gets rotated/audited by the security team, and not something we have to maintain.
This is a public repo, so I can't link here to internal stuff, but this is blocked on an internal PR to setup the federation link.