Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

Expose class on global #5

Merged
merged 10 commits into from
Mar 25, 2021
Merged

Expose class on global #5

merged 10 commits into from
Mar 25, 2021

Conversation

keithamus
Copy link
Contributor

This adds the expose-class-on-global rule.

This rule enforces that any class extending from HTMLElement also be assigned to a global variable matching that name.

Refs #3

This will be useful for tracking class references in a given context
object. This will simplify rule development where define calls reference
a class in the scope.
This can be a place to house commonly used selectors which are complex
and subtle
@keithamus keithamus mentioned this pull request Mar 23, 2021
16 tasks
@keithamus keithamus force-pushed the expose-class-on-global branch from 6772480 to 351ce6c Compare March 24, 2021 16:13
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me ✨

@keithamus keithamus merged commit 1db5441 into main Mar 25, 2021
@keithamus keithamus deleted the expose-class-on-global branch March 25, 2021 10:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants