Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

relax extends-correct-class rule for imports #53

Merged
merged 2 commits into from
Jan 3, 2023
Merged

relax extends-correct-class rule for imports #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f159c0
relax extends-correct-class rule for imports
keithamus Nov 30, 2022
3453ad2
Merge branch 'main' into relax-extends-correct-class-rule-for-imports
keithamus Jan 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/rules/extends-correct-class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ module.exports = {
[s.customElements.define](node) {
const classRef = classes.get(node.arguments[1])
if (!classRef) return
if (classRef.type === 'ImportDefaultSpecifier' || classRef.type === 'ImportSpecifier') return
const extendsTag = getExtendsOption(node.arguments[2])

// Allowed super names is an array of allowed names.
Expand Down
8 changes: 7 additions & 1 deletion test/extends-correct-class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const rule = require('../lib/rules/extends-correct-class')
const RuleTester = require('eslint').RuleTester

const ruleTester = new RuleTester({env: {es2020: true}})
const ruleTester = new RuleTester({env: {es2020: true}, parserOptions: {sourceType: 'module'}})

ruleTester.run('extends-correct-class', rule, {
valid: [
Expand All @@ -16,6 +16,12 @@ ruleTester.run('extends-correct-class', rule, {
code: 'customElements.define("foo-bar", class extends HTMLElement {})',
options: [{allowedSuperNames: ['HTMLGitHubElement']}],
},
{
code: 'import Foo from "other";customElements.define("foo-bar", Foo)',
},
{
code: 'import {Foo} from "other";customElements.define("foo-bar", Foo)',
},
],
invalid: [
{
Expand Down