Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

add eslint-plugin-eslint-plugin and fix failures #56

Merged
merged 2 commits into from
Apr 9, 2023
Merged

add eslint-plugin-eslint-plugin and fix failures #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cbb72e
add eslint-plugin-eslint-plugin and fix failures
keithamus Jan 13, 2023
6f53f1a
Merge branch 'main' into add-eslint-plugin-eslint-plugin-and-fix-fail…
keithamus Apr 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ module.exports = {
env: {
node: true,
},
extends: ['plugin:github/recommended'],
extends: ['plugin:github/recommended', 'plugin:eslint-plugin/recommended'],
rules: {
'i18n-text/no-en': 'off',
'import/no-commonjs': 'off',
'eslint-plugin/require-meta-docs-url': 'error',
},
overrides: [
{
Expand Down
44 changes: 44 additions & 0 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
"eslint": "^8.28.0",
"eslint-config-prettier": "^8.5.0",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-eslint-plugin": "^5.0.7",
"eslint-plugin-github": "^4.4.1",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-prettier": "^4.2.1",
Expand Down
1 change: 0 additions & 1 deletion test/file-name-matches-element.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ ruleTester.run('file-name-matches-element', rule, {
{code, filename: 'foo_bar.js', options: [{transform: ['kebab', 'snake', 'pascal'], suffix: 'Element'}]},
{code, filename: 'foo_bar_element.js', options: [{transform: ['kebab', 'snake'], suffix: ['Element']}]},
{code, filename: 'fooBarElement.js', options: [{transform: ['kebab', 'pascal'], suffix: ['ElEmEnT']}]},
{code, filename: 'foo_bar_element.js', options: [{transform: ['kebab', 'snake'], suffix: ['Element']}]},
{code, filename: 'bar_element.js', options: [{transform: ['kebab', 'snake'], prefix: ['Foo']}]},
{code, filename: 'bar_element.js', options: [{transform: ['kebab', 'snake'], prefix: ['fOo']}]},
{
Expand Down
1 change: 0 additions & 1 deletion test/tag-name-matches-class.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ ruleTester.run('tag-name-matches-class', rule, {
{code: "customElements.define('foo-bar-element', FooBarElement)"},
{code: "customElements.define('foo-bar', FooBar)", options: [{suffix: ['Element']}]},
{code: "customElements.define('foo-bar', FooBarElement)", options: [{suffix: ['Element']}]},
{code: "customElements.define('foo-bar', FooBarElement)", options: [{suffix: ['Element']}]},
{code: "customElements.define('foo-bar', FooBarComponent)", options: [{suffix: 'Component'}]},
{code: "customElements.define('foo-bar', FooBarElement)", options: [{suffix: ['Element', 'Component']}]},
{code: "customElements.define('foo-bar', FooBarComponent)", options: [{suffix: ['Element', 'Component']}]},
Expand Down
15 changes: 0 additions & 15 deletions test/valid-tag-name.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ ruleTester.run('valid-tag-name', rule, {
{code: 'customElements.define("foo-bar")'},
{code: "customElements.define('foo-bar')"},
{code: 'customElements.define(`foo-bar`)'},
{code: 'customElements.define("foo-bar")'},
{code: 'customElements.define("m---···---")'},
{code: 'customElements.define("aÀ-")'},
{code: 'customElements.define("leiðinlegt-tíst")'},
Expand Down Expand Up @@ -104,20 +103,6 @@ ruleTester.run('valid-tag-name', rule, {
},
],
},
{
code: 'customElements.define("a-😶‍🌫️")',
options: [
{
onlyAlphanum: true,
},
],
errors: [
{
message: 'Non ASCII Custom Elements have been disallowed',
type: 'Literal',
},
],
},
{
code: 'customElements.define("ng-element")',
options: [
Expand Down