Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Sep 18, 2023. It is now read-only.

file-name-matches-element: Fix case of missing name #58

Merged
merged 2 commits into from
Apr 9, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions lib/rules/file-name-matches-element.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,11 @@ module.exports = {
if (!hasFileName(context)) return {}
return {
[s.HTMLElementClass](node) {
const name = node.id.name
const names = [name]
const name = node.id?.name
const names = []
if (name) {
names.push(name)
}
const filename = basename(context.getFilename(), extname(context.getFilename()))
const transforms = [].concat(context.options?.[0]?.transform || ['kebab', 'pascal'])
const suffixes = [].concat(context.options?.[0]?.suffix || [])
Expand All @@ -66,7 +69,7 @@ module.exports = {
allowedFileNames.add(transformFuncs[transform](className))
}
}
if (!allowedFileNames.has(filename)) {
if (allowedFileNames.size && !allowedFileNames.has(filename)) {
const allowed = Array.from(allowedFileNames).join('" or "')
context.report(node, `File name should be "${allowed}" but was "${filename}"`)
}
Expand Down
4 changes: 4 additions & 0 deletions test/file-name-matches-element.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,10 @@ ruleTester.run('file-name-matches-element', rule, {
filename: 'components/foo/foo-bar.ts',
options: [{transform: 'kebab', suffix: ['Controller']}],
},
{
code: 'window.customElements.define("foo-bar", class extends HTMLElement {})',
filename: 'any.js',
},
],
invalid: [
{
Expand Down