Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Suggest using textContent instead of innerHTML #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 14, 2021
Merged

Suggest using textContent instead of innerHTML #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21c911e
Suggest using textContent instead of innerHTML
manuelpuyol Sep 10, 2021
ab6b649
Update docs/rules/no-innter-html.md
manuelpuyol Sep 13, 2021
ef585ab
Simplify rule selector
koddsson Sep 13, 2021
8a0b80c
remove autocorrecting"
manuelpuyol Sep 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/rules/no-innter-html.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# No `innerHTML`

Using `innerHTML` poses a potential security risk. It should only be used when clearing content.
Using `innerHTML` poses a potential security risk. Prefer using `textContent` to set text to an element.

```js
// bad
Expand All @@ -9,8 +9,8 @@ function setContent(element, content) {
}

// good
function clearContent(element) {
element.innerHTML = ''
function setContent(element, content) {
element.textContent = content
}
```

Expand Down
24 changes: 6 additions & 18 deletions lib/rules/no-inner-html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,31 +2,19 @@ module.exports = {
meta: {
type: 'problem',
docs: {
description: 'disallow `Element.prototype.innerHTML``',
description: 'disallow `Element.prototype.innerHTML` in favor of `Element.prototype.textContent`',
url: require('../url')(module)
},
schema: []
},

create(context) {
return {
AssignmentExpression(node) {
if (node.operator === '=') {
const leftNode = node.left
const rightNode = node.right

if (leftNode.property && leftNode.property.name === 'innerHTML') {
if (rightNode.type === 'Literal' && rightNode.value === '') {
return
}

context.report({
node,
message:
'Using innerHTML poses a potential security risk and should not be used other than clearing content.'
})
}
}
'MemberExpression[property.name=innerHTML]': function (node) {
context.report({
node: node.property,
message: 'Using innerHTML poses a potential security risk and should not be used. Prefer using textContent.'
})
}
}
}
Expand Down
24 changes: 17 additions & 7 deletions tests/no-inner-html.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,27 +6,37 @@ const ruleTester = new RuleTester()
ruleTester.run('no-innter-html', rule, {
valid: [
{
code: 'document.createElement("js-flash-text").innerHTML = ""'
code: 'document.createElement("js-flash-text").textContent = ""'
},
{
code: 'document.createElement("js-flash-text").textContent = "foo"'
}
],
invalid: [
{
code: 'document.createElement("js-flash-text").innerHTML = "foo"',
errors: [
{
message:
'Using innerHTML poses a potential security risk and should not be used other than clearing content.',
type: 'AssignmentExpression'
message: 'Using innerHTML poses a potential security risk and should not be used. Prefer using textContent.',
type: 'Identifier'
}
]
},
{
code: 'document.querySelector("js-flash-text").innerHTML = "<div>code</div>"',
errors: [
{
message:
'Using innerHTML poses a potential security risk and should not be used other than clearing content.',
type: 'AssignmentExpression'
message: 'Using innerHTML poses a potential security risk and should not be used. Prefer using textContent.',
type: 'Identifier'
}
]
},
{
code: 'document.querySelector("js-flash-text").innerHTML = ""',
errors: [
{
message: 'Using innerHTML poses a potential security risk and should not be used. Prefer using textContent.',
type: 'Identifier'
}
]
}
Expand Down