Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 8 commits
- 5 files changed
- 2 contributors
Commits on Aug 30, 2021
-
Surface event for file-attachment-dragged
The implementation for github/github#190219 needs an event to kick off finding the cursor position, and rather than bubbling the DragEvent it seems prudent to fire a CustomEvent solely used by that consumer. That'll avoid any unintended side effects in the document at large.
-
Commits on Aug 31, 2021
Commits on Sep 1, 2021
-
-
Bubble original event rather than a new custom one
We decided we could use the `dragover` and `dragenter` events directly instead of wrapping them with a custom one. We're still calling `preventDefault()` so we won't accidentally trigger any native behavior downstream.
Commits on Sep 3, 2021
-
Merge pull request #14 from github/bestra/file-attachment-dragged-event
Bubble dragover and dragenter events
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.0.1...v3.0.0