Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make add/add-wizard and update manifest-aware for aw.yml package installs #34008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pelikhan merged 9 commits into from
May 22, 2026
Merged

Make add/add-wizard and update manifest-aware for aw.yml package installs #34008

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6acb1b8
Implement manifest-based source and manifest-aware update flow
Copilot May 22, 2026
1982039
Format and refine manifest update implementation
Copilot May 22, 2026
741a9ee
Address review feedback in manifest update changes
Copilot May 22, 2026
fa3a1ec
Harden manifest update grouping logic
Copilot May 22, 2026
286984a
Add draft ADR-34008 for manifest-scoped source tracking and update or…
github-actions[bot] May 22, 2026
395d193
Plan: address PR review comments
Copilot May 22, 2026
68f443b
Fix merge source normalization and remove dead manifest error branch
Copilot May 22, 2026
28f8344
Address review feedback for manifest merge/update follow-ups
Copilot May 22, 2026
eb05f5e
Add integration coverage for manifest add then update flow
Copilot May 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add integration coverage for manifest add then update flow 
Co-authored-by: pelikhan <[email protected]>
  • Loading branch information
@pelikhan
Copilot and pelikhan authored May 22, 2026
commit eb05f5eadb635d32b60380e5cfabd3079d436e23
40 changes: 40 additions & 0 deletions pkg/cli/update_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,46 @@ func TestUpdateCommand_RepoFlag(t *testing.T) {
assert.NotContains(t, outputStr, "unknown flag", "The --repo flag should be recognized")
}

// TestUpdateCommand_AfterManifestAddIntegration verifies a manifest package can be
// added and then updated in place.
func TestUpdateCommand_AfterManifestAddIntegration(t *testing.T) {
skipWithoutGitHubAuth(t)

setup := setupUpdateIntegrationTest(t)
defer setup.cleanup()

addCmd := exec.Command(setup.binaryPath, "add", "githubnext/agentic-ops@v-1", "--verbose")
addCmd.Dir = setup.tempDir
addOutput, addErr := addCmd.CombinedOutput()
addOutputStr := string(addOutput)
require.NoError(t, addErr, "add command should succeed: %s", addOutputStr)

entries, err := os.ReadDir(setup.workflowsDir)
require.NoError(t, err, "should read workflows directory")
require.NotEmpty(t, entries, "add should create at least one workflow")

var workflowPath string
for _, entry := range entries {
if entry.IsDir() || !strings.HasSuffix(entry.Name(), ".md") {
continue
}
workflowPath = filepath.Join(setup.workflowsDir, entry.Name())
break
}
require.NotEmpty(t, workflowPath, "expected at least one markdown workflow file")

content, err := os.ReadFile(workflowPath)
require.NoError(t, err, "should read added workflow")
assert.Contains(t, string(content), "source: githubnext/agentic-ops@", "workflow source should be manifest-scoped")

updateCmd := exec.Command(setup.binaryPath, "update", "--verbose")
updateCmd.Dir = setup.tempDir
updateOutput, updateErr := updateCmd.CombinedOutput()
updateOutputStr := string(updateOutput)
require.NoError(t, updateErr, "update command should succeed after manifest add: %s", updateOutputStr)
assert.NotContains(t, updateOutputStr, "no workflows found", "update should detect added workflows")
}

// --- Merge Behavior Integration Tests ---

// TestUpdateCommand_MergeIsDefault verifies that merge is the default behavior
Expand Down