feat: add .sentrux/rules.toml with architectural quality gates#34062
Merged
Conversation
Co-authored-by: pelikhan <[email protected]>
…_files floors Co-authored-by: pelikhan <[email protected]>
Copilot
AI
changed the title
[WIP] Create .sentrux/rules.toml with quality, coupling, and cycles floors
feat: add .sentrux/rules.toml with architectural quality gates
May 22, 2026
pelikhan
approved these changes
May 22, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a Sentrux ruleset so the existing Daily Sentrux Report workflow can enforce architectural quality gates (instead of reporting “No rules defined”), and includes workflow lock/pin updates that affect CI/release behavior.
Changes:
- Add
.sentrux/rules.tomldefining four Sentrux metric constraints (quality floor, coupling ceiling, cycles max, god-files max). - Update
release.lock.ymlto use a different pinned revision ofdocker/setup-buildx-action. - Update
developer-docs-consolidator.lock.yml(notably the schedule cron) and refresh associated lock metadata; adddocker/setup-buildx-action@v4to actions lock data.
Show a summary per file
| File | Description |
|---|---|
.sentrux/rules.toml |
Introduces Sentrux architectural rules to enable enforcement in sentrux check .. |
.github/workflows/release.lock.yml |
Updates the pinned docker/setup-buildx-action revision used by the release workflow. |
.github/workflows/developer-docs-consolidator.lock.yml |
Updates lock metadata and changes the workflow schedule cron (daily → weekly). |
.github/aw/actions-lock.json |
Adds a new pinned entry for docker/setup-buildx-action@v4 to support workflow locking. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 4/4 changed files
- Comments generated: 3
Comment on lines
67
to
+71
| name: "Developer Documentation Consolidator" | ||
| on: | ||
| schedule: | ||
| - cron: "19 13 * * *" | ||
| # Friendly format: daily (scattered) | ||
| - cron: "19 13 * * 6" | ||
| # Friendly format: weekly (scattered) |
Comment on lines
1374
to
1376
| - name: Setup Docker Buildx (pre-validation) | ||
| uses: docker/setup-buildx-action@4d04d5d9486b7bd6fa91e7baf45bbb4f8b9deedd # v4.0.0 (source v4) | ||
| uses: docker/setup-buildx-action@d7f5e7f509e45cec5c76c4d5afdd7de93d0b3df5 # v4 | ||
| - name: Build Docker image (validation only) |
Comment on lines
+151
to
+155
| "docker/setup-buildx-action@v4": { | ||
| "repo": "docker/setup-buildx-action", | ||
| "version": "v4", | ||
| "sha": "d7f5e7f509e45cec5c76c4d5afdd7de93d0b3df5" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Daily Sentrux Report has been emitting "⚠️ No rules defined" on every run, making it purely informational with no regression detection. Quality has silently slid 5315→5222 and coupling jumped 0.04→0.195 over ~10 days.
Changes
.sentrux/rules.toml— adds four architectural constraint rules:The
daily-sentrux-reportworkflow already runssentrux check .and parses rule violations when.sentrux/rules.tomlis present — no workflow changes needed. Floors are set conservatively at current observed values to avoid immediate failures while still catching future regression.