Remove deprecated model state; retain full multiplier history#34079
Merged
Conversation
Co-authored-by: pelikhan <[email protected]>
Co-authored-by: pelikhan <[email protected]>
Copilot
AI
changed the title
Remove deprecated model state and retain full model history
Remove deprecated model state; retain full multiplier history
May 22, 2026
Copilot created this pull request from a session on behalf of
pelikhan
May 22, 2026 17:42
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request removes the deprecated-model metadata field from Effective Tokens model multiplier payloads and updates policy/docs/tests to treat multiplier registries as full historical inventories that only change via explicit manual deletion.
Changes:
- Removed the
deprecated_modelstop-level field from the Go-embedded and JS action copies ofmodel_multipliers.json. - Updated the Effective Tokens specification (R-REG-009) and daily inventory guidance to retain historical model entries instead of proposing automatic removals.
- Updated Go tests to align with the new payload shape, and added a patch changeset documenting the policy transition.
Show a summary per file
| File | Description |
|---|---|
pkg/cli/effective_tokens_test.go |
Removes assertions that depended on deprecated_models metadata. |
pkg/cli/data/model_multipliers.json |
Drops deprecated_models and updates registry description to reflect historical retention policy. |
actions/setup/js/model_multipliers.json |
Drops deprecated_models and updates registry description for the JS action payload. |
docs/src/content/docs/reference/effective-tokens-specification.md |
Updates R-REG-009 and sync guidance to require full history retention + manual deletion. |
.github/workflows/daily-model-inventory.md |
Adjusts daily inventory guidance to report “historical” entries rather than propose removals. |
.changeset/patch-model-inventory-2026-05-22.md |
Adds release note for the policy/payload change. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
actions/setup/js/model_multipliers.json:5
- This JS action’s
model_multipliers.jsonappears to be drifting from the authoritative registry atpkg/cli/data/model_multipliers.json(for example, the CLI registry containsgemini-3-pro/gemini-3.1-pro, but they are absent here). Sincesetup.shexports this file asGH_AW_MODEL_MULTIPLIERS, missing entries will cause the JS ET calculator to fall back to 1.0 for those models, producing inconsistent ET results vs the CLI/spec. Consider generating this file from the CLI registry (or otherwise enforcing parity) so both runtimes compute ET from the same multiplier table.
"description": "Effective Tokens (ET) computation data per the gh-aw Effective Tokens Specification v0.2.0. Token class weights are applied first to normalize across token classes, then the per-model multiplier scales the result relative to the reference model. The registry keeps complete model history; entries are removed only by explicit manual deletion.",
"reference_model": "claude-sonnet-4.5",
"token_class_weights": {
- Files reviewed: 6/6 changed files
- Comments generated: 2
| "version": "1", | ||
| "description": "Effective Tokens (ET) computation data per the gh-aw Effective Tokens Specification v0.2.0. Token class weights are applied first to normalize across token classes, then the per-model multiplier scales the result relative to the reference model. Model lifecycle: deprecated models must carry a deprecated marker for one minor version before removal (R-REG-009).", | ||
| "description": "Effective Tokens (ET) computation data per the gh-aw Effective Tokens Specification v0.2.0. Token class weights are applied first to normalize across token classes, then the per-model multiplier scales the result relative to the reference model. The registry keeps complete model history; entries are removed only by explicit manual deletion.", | ||
| "reference_model": "claude-sonnet-4.5", |
| "version": "1", | ||
| "description": "Effective Tokens (ET) computation data per the gh-aw Effective Tokens Specification v0.2.0. Token class weights are applied first to normalize across token classes, then the per-model multiplier scales the result relative to the reference model. Model lifecycle: deprecated models must carry a deprecated marker for one minor version before removal (R-REG-009).", | ||
| "description": "Effective Tokens (ET) computation data per the gh-aw Effective Tokens Specification v0.2.0. Token class weights are applied first to normalize across token classes, then the per-model multiplier scales the result relative to the reference model. The registry keeps complete model history; entries are removed only by explicit manual deletion.", | ||
| "reference_model": "claude-sonnet-4.5", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes deprecated-model state from multiplier payloads and shifts the model inventory policy to full history retention. The daily updater and docs now treat unseen models as historical records that remain until explicitly deleted.
Registry payload cleanup
deprecated_modelsfrom:pkg/cli/data/model_multipliers.jsonactions/setup/js/model_multipliers.jsonPolicy and schema-aligned guidance
R-REG-009indocs/src/content/docs/reference/effective-tokens-specification.md:.github/workflows/daily-model-inventory.mdto stop proposing automatic stale-model removal and instead report historical entries not currently returned by providers.Test alignment
pkg/cli/effective_tokens_test.goso tests validate the new payload shape and behavior model.Release note
.changeset/patch-model-inventory-2026-05-22.mddocumenting the policy transition.{ "version": "1", "description": "... complete model history ... removed only by explicit manual deletion.", "reference_model": "claude-sonnet-4.5", "token_class_weights": { "input": 1.0, "cached_input": 0.1, "output": 4.0, "reasoning": 4.0, "cache_write": 1.0 }, "multipliers": { "gpt-5.5": 7.5 } }