[log] Add debug logging to delegation RuntimeConfig - #13064
Draft
github-actions[bot] wants to merge 1 commit into
Draft
[log] Add debug logging to delegation RuntimeConfig#13064github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
Add logConfig logger (namespace delegation:config) to internal/delegation/config.go and log meaningful events in Validate() and ControlDeps(): - each validation failure branch (nil config, missing store, missing capability, missing state path) - successful validation with statePath/controlListenAddr - ControlDeps() called on a nil config (delegation disabled) Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds debug logging to
internal/delegation/config.go, which previously had no logger despite containing meaningful startup validation logic used by bothinternal/server/unified.goandinternal/proxy/proxy.go.Changes
logConfiglogger vialogger.ForFile()(namespacedelegation:config).RuntimeConfig.Validate(): logs each of the four failure branches (nil config, missing store, missing capability, missing state path) plus a success log includingstatePathandcontrolListenAddr.RuntimeConfig.ControlDeps(): logs when called on a nil config, since that path silently returns a zero value that disables delegation control.Validation
go build -o awmg ./...— succeedsgo vet ./internal/delegation/...— cleango test ./internal/delegation/...— passesgofmt -l internal/delegation/config.go— no issues