Allow templating {{input}} in prompt files #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enables using a {{input}} placeholder in .prompt.yml files to substitute stdin content into user messages when running gh models run --file. It adds a pipedContent variable in run.go to capture and inject stdin data, updates the command logic to replace {{input}} in user roles, and adds corresponding tests in run_test.go.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cmd/run/run.go | Introduce pipedContent, read from stdin when piped, and replace {{input}} in user messages from prompt files. Adjust interactive prompting and loop break conditions to support file-based runs. |
| cmd/run/run_test.go | Remove outdated static prompt assertion and add a new test verifying that {{input}} is substituted with piped stdin content in prompt files. |
Comments suppressed due to low confidence (1)
cmd/run/run.go:294
- We should add tests covering multiple
{{input}}occurrences within a single message and verify that placeholders in non-userroles are not replaced to ensure the substitution logic behaves correctly in all scenarios.
if pipedContent != "" && strings.ToLower(m.Role) == "user" {
stevenlaidlaw
approved these changes
May 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the prompt yml file passed contains an
{{input}}, we should template that in from stdin.I considered using a separate
--inputparameter, but templated fields might be pretty large, so stdin seems like a better fit.