Add android-arm64 to release scripts #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds Android build targets to the release and build scripts to support android-arm64 and android-amd64.
- Include new Android binaries in the upload script
- Invoke
go buildfor Android arm64 and amd64 in the build script
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| script/upload-release | Added gh-models-android-arm64 and gh-models-android-amd64 to the list of release binaries |
| script/build | Added build steps for GOOS=android GOARCH=arm64 and GOOS=android GOARCH=amd64 |
Comments suppressed due to low confidence (1)
script/upload-release:14
- [nitpick] Consider ordering entries in
BINARIESalphabetically (e.g., placingandroid-amd64beforeandroid-arm64) for consistency and readability.
BINARIES="gh-models-darwin-amd64 gh-models-darwin-arm64 gh-models-linux-amd64 gh-models-windows-amd64.exe gh-models-android-arm64 gh-models-android-amd64"
Yuzuki-S
approved these changes
May 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43
Build the extension for android-arm64. Builds fine locally so I assume it'll build and release in CI as well.