Set android SDK version #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR ensures the Android SDK version is explicitly set in the release workflow and removes the x86_64 Android build/upload steps for consistency.
- Drop
gh-models-android-amd64from build and release artifacts - Add
android_sdk_version: 34input to the GitHub Actions release workflow
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| script/upload-release | Removed gh-models-android-amd64 from the BINARIES list |
| script/build | Removed GOOS=android GOARCH=amd64 build to stop creating amd64 APK |
| .github/workflows/release.yml | Added android_sdk_version: 34 to the with: section of the release job |
Yuzuki-S
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the SDK version in our release action, since apparently it's mandatory. I chose 34 out of consistency with other GitHub CLI extensions.