Additional query attributes option for Member search strategy #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtodd
added a commit
that referenced
this pull request
Dec 3, 2014
Additional query attritbutes option for Member search strategy
| @@ -9,7 +9,7 @@ class Recursive | |||
| include Filter | |||
|
|
|||
| DEFAULT_MAX_DEPTH = 9 | |||
| ATTRS = %w(member uniqueMember memberUid) | |||
| DEFAULT_ATTRS = %w(member uniqueMember memberUid) | |||
There was a problem hiding this comment.
This existed before, so I'm not asking for a change, but are these standard LDAP attributes? Or are they attributes we expect when using this strategy?
There was a problem hiding this comment.
Both, really. member and uniqueMember are attributes of the groupOfNames and groupOfUniqueNames object classes (and Active Directory's group category), and memberUid is for the posixGroup object class.
Hardcoding these here (and elsewhere) is a smell. Addressing that smell is a fairly large engineering undertaking that isn't possible right now. I have some ideas I'd like to run by you, though, for the future.
|
👍 makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an option for the Member search strategy to include attributes in member queries. This allows us to specify attributes like
objectClassin addition to the required member attributes for other purposes (like filtering out groups byobjectClass).cc @jch