Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add support for ldap referral chasing #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

add support for ldap referral chasing #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions lib/github/ldap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
require 'net/ldap'
require 'forwardable'
require 'uri'

require 'github/ldap/filter'
require 'github/ldap/domain'
Expand Down Expand Up @@ -100,6 +101,9 @@ def initialize(options = {})

# enables instrumenting queries
@instrumentation_service = options[:instrumentation_service]

# referral connection handle
@referrals = {}
end

# Public - Whether membership checks should recurse into nested groups when
Expand Down Expand Up @@ -187,7 +191,51 @@ def search(options, &block)
result.concat Array(rs) unless rs == false
end
end
if options[:return_referrals]
ref_result = []
result.delete_if do |entry|
if entry.respond_to?('search_referrals')
rs = search_referrals(entry[:search_referrals], options, &block)
ref_result.concat Array(rs) unless rs == false
true
else
false
end
end
result.concat ref_result
end
return [] if result == false
Array(result)
end
end

# Internal: Searches the referral LDAP servers
#
# referal_hosts: list of referral hosts uris
# options: is a hash with the same options that Net::LDAP::Connection#search supports.
# block: is an optional block to pass to the search.
#
# Returns an Array of Net::LDAP::Entry.
def search_referrals(referral_uris, options, &block)
instrument "search_referrals.github_ldap", options.dup do |payload|
options.delete(:return_referrals)
result = []
referral_uris.each do |referral_url|
unless @referrals.has_key? referral_url
uri = URI(referral_url)
@referrals[referral_url] = Net::LDAP.new({
host: uri.host,
port: uri.port,
base: uri.path.sub(/^\//, ''),
auth: @connection.instance_variable_get(:@auth),
encryption: @connection.instance_variable_get(:@encryption),
instrumentation_service: @connection.instance_variable_get(:@instrumentation_service)
})
end
options.delete(:base)
rs = @referrals[referral_url].search(options, &block)
result.concat Array(rs) unless rs == false
end
return [] if result == false
Array(result)
end
Expand Down
5 changes: 3 additions & 2 deletions lib/github/ldap/member_search/recursive.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ def find_groups_by_dn(dn)
base: dn,
scope: Net::LDAP::SearchScope_BaseObject,
attributes: attrs,
filter: ALL_GROUPS_FILTER
filter: ALL_GROUPS_FILTER,
return_referrals: true
end
private :find_groups_by_dn

Expand All @@ -133,7 +134,7 @@ def find_groups_by_dn(dn)
def entries_by_uid(members)
filter = members.map { |uid| Net::LDAP::Filter.eq(ldap.uid, uid) }.reduce(:|)
domains.each_with_object([]) do |domain, entries|
entries.concat domain.search(filter: filter, attributes: attrs)
entries.concat domain.search(filter: filter, attributes: attrs, return_referrals: true)
end.compact
end
private :entries_by_uid
Expand Down
4 changes: 2 additions & 2 deletions lib/github/ldap/membership_validators/recursive.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ def perform(entry, depth_override = nil)

domains.each do |domain|
# find groups entry is an immediate member of
membership = domain.search(filter: member_filter(entry), attributes: ATTRS)
membership = domain.search(filter: member_filter(entry), attributes: ATTRS, return_referrals: true)

# success if any of these groups match the restricted auth groups
return true if membership.any? { |entry| group_dns.include?(entry.dn) }
Expand All @@ -62,7 +62,7 @@ def perform(entry, depth_override = nil)
# recurse to at most `depth`
(depth_override || depth).times do |n|
# find groups whose members include membership groups
membership = domain.search(filter: membership_filter(membership), attributes: ATTRS)
membership = domain.search(filter: membership_filter(membership), attributes: ATTRS, return_referrals: true)

# success if any of these groups match the restricted auth groups
return true if membership.any? { |entry| group_dns.include?(entry.dn) }
Expand Down