-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: fix e2e tests #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
chore: fix e2e tests #536
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,6 @@ package e2e_test | |
|
|
||
| import ( | ||
| "context" | ||
| "encoding/base64" | ||
| "encoding/json" | ||
| "fmt" | ||
| "net/http" | ||
|
|
@@ -508,17 +507,14 @@ func TestFileDeletion(t *testing.T) { | |
| require.NoError(t, err, "expected to call 'get_file_contents' tool successfully") | ||
| require.False(t, resp.IsError, fmt.Sprintf("expected result not to be an error: %+v", resp)) | ||
|
|
||
| textContent, ok = resp.Content[0].(mcp.TextContent) | ||
| require.True(t, ok, "expected content to be of type TextContent") | ||
| embeddedResource, ok := resp.Content[1].(mcp.EmbeddedResource) | ||
| require.True(t, ok, "expected content to be of type EmbeddedResource") | ||
|
|
||
| var trimmedGetFileText struct { | ||
| Content string `json:"content"` | ||
| } | ||
| err = json.Unmarshal([]byte(textContent.Text), &trimmedGetFileText) | ||
| require.NoError(t, err, "expected to unmarshal text content successfully") | ||
| b, err := base64.StdEncoding.DecodeString(trimmedGetFileText.Content) | ||
| require.NoError(t, err, "expected to decode base64 content successfully") | ||
| require.Equal(t, fmt.Sprintf("Created by e2e test %s", t.Name()), string(b), "expected file content to match") | ||
| // raw api | ||
| textResource, ok := embeddedResource.Resource.(mcp.TextResourceContents) | ||
| require.True(t, ok, "expected embedded resource to be of type TextResourceContents") | ||
|
|
||
| require.Equal(t, fmt.Sprintf("Created by e2e test %s", t.Name()), textResource.Text, "expected file content to match") | ||
|
|
||
| // Delete the file | ||
| deleteFileRequest := mcp.CallToolRequest{} | ||
|
|
@@ -703,17 +699,14 @@ func TestDirectoryDeletion(t *testing.T) { | |
| require.NoError(t, err, "expected to call 'get_file_contents' tool successfully") | ||
| require.False(t, resp.IsError, fmt.Sprintf("expected result not to be an error: %+v", resp)) | ||
|
|
||
| textContent, ok = resp.Content[0].(mcp.TextContent) | ||
| require.True(t, ok, "expected content to be of type TextContent") | ||
| embeddedResource, ok := resp.Content[1].(mcp.EmbeddedResource) | ||
| require.True(t, ok, "expected content to be of type EmbeddedResource") | ||
|
|
||
| var trimmedGetFileText struct { | ||
| Content string `json:"content"` | ||
| } | ||
| err = json.Unmarshal([]byte(textContent.Text), &trimmedGetFileText) | ||
| require.NoError(t, err, "expected to unmarshal text content successfully") | ||
| b, err := base64.StdEncoding.DecodeString(trimmedGetFileText.Content) | ||
| require.NoError(t, err, "expected to decode base64 content successfully") | ||
| require.Equal(t, fmt.Sprintf("Created by e2e test %s", t.Name()), string(b), "expected file content to match") | ||
| // raw api | ||
| textResource, ok := embeddedResource.Resource.(mcp.TextResourceContents) | ||
| require.True(t, ok, "expected embedded resource to be of type TextResourceContents") | ||
|
|
||
| require.Equal(t, fmt.Sprintf("Created by e2e test %s", t.Name()), textResource.Text, "expected file content to match") | ||
|
|
||
|
Comment on lines
+702
to
710
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same pattern repeated here in Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
| // Delete the directory containing the file | ||
| deleteFileRequest := mcp.CallToolRequest{} | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indexing (
resp.Content[1]) and type assertion logic is duplicated in both tests. Consider extracting a helper likegetTextFromEmbedded(resp)to improve readability and reduce duplication.Copilot uses AI. Check for mistakes.