This repository was archived by the owner on Jan 31, 2019. It is now read-only.
Receive pull requests as well as issues, and add test for it #1006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hi, any update on this? Thanks! |
Member
|
Hey @calexicoz! We only generally review things once a week so sorry for the delay on this. I'll merge this in. Just so you know, existing services won't be updated with the new events you're adding here. Services get "locked" to the events the service has when that service is installed. If a user removes the service and re-adds it, they would be able to get the new events you want. (If you used webhooks via OAuth and the API, your app could control what events are used.) |
kdaigle
added a commit
that referenced
this pull request
Jan 14, 2015
Receive pull requests as well as issues, and add test for it
Contributor
Author
|
Great. Thanks for letting me know. I'll update the services I have access to on my side. And thanks for merging this :) |
Member
|
This will go live later today. 🍰 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.